Other than that I am happy with the changes.
Thanks
-----Original Message-----
From: Pramod Gopinath [mailto:pramod.gopinath_at_sun.com]
Sent: Tuesday, December 06, 2005 3:53 PM
To: Marina Vatkina
Cc: Peter Krogh; king.wang_at_oracle.com; ejb3-toplink-ext_at_Sun.COM; Robert Campbell; persistence_at_glassfish.dev.java.net; Mitesh Meswani
Subject: Re: Code review files related to java2db case where the sql tokens shouldnot be written out
Hi Marina
U are right. I will change the name to setCreateSQLFiles().
Thanks
Pramod
Marina Vatkina wrote:
Pramod,
Should shouldCreateSQLFiles() be called setCreateSQLFiles()?
thanks,
-marina
Pramod Gopinath wrote:
Hi Peter
Based on our discussion today I am sending out the diffs and the files
that have been modified to take care of not writing out the sql string
tokens in case of java2db.
The affected files are
oracle/toplink/essentials/ejb/cmp3/EntityManagerFactoryProvider.java &
oracle/toplink/essentials/tools/schemaframework/SchemaManager.java
Thanks for Ur help
Pramod
--------------------------------------------------------------------------------
Name: diff_SQLToken
diff_SQLToken Type: Plain Text (text/plain)
Encoding: 7BIT
Name: EntityManagerFactoryProvider.java
EntityManagerFactoryProvider.java Type: text/x-java
Encoding: 7BIT
Name: SchemaManager.java
SchemaManager.java Type: text/x-java
Encoding: 7BIT