persistence@glassfish.java.net

Code review files related to java2db case where the sql tokens should not be written out

From: Pramod Gopinath <Pramod.Gopinath_at_Sun.COM>
Date: Tue, 06 Dec 2005 12:43:07 -0800

Hi Peter
  Based on our discussion today I am sending out the diffs and the files
that have been modified to take care of not writing out the sql string
tokens in case of java2db.

The affected files are
oracle/toplink/essentials/ejb/cmp3/EntityManagerFactoryProvider.java &
oracle/toplink/essentials/tools/schemaframework/SchemaManager.java

Thanks for Ur help
Pramod



Index: ejb/cmp3/EntityManagerFactoryProvider.java
===================================================================
RCS file: /cvs/glassfish/entity-persistence/src/java/oracle/toplink/essentials/ejb/cmp3/EntityManagerFactoryProvider.java,v
retrieving revision 1.6
diff -r1.6 EntityManagerFactoryProvider.java
189a190
> mgr.shouldCreateSQLFiles(false);
Index: tools/schemaframework/SchemaManager.java
===================================================================
RCS file: /cvs/glassfish/entity-persistence/src/java/oracle/toplink/essentials/tools/schemaframework/SchemaManager.java,v
retrieving revision 1.3
diff -r1.3 SchemaManager.java
58a59
> protected boolean createSQLFiles = true;
154,155c155,157
< this.appendToDDLWriter(createSchemaWriter,
< getSession().getPlatform().getStoredProcedureTerminationToken());
---
>             if(createSQLFiles)
>                 this.appendToDDLWriter(createSchemaWriter,
>                     getSession().getPlatform().getStoredProcedureTerminationToken());
356,357c358,360
<             this.appendToDDLWriter(dropSchemaWriter,
<                 getSession().getPlatform().getStoredProcedureTerminationToken());
---
>             if(createSQLFiles)
>                 this.appendToDDLWriter(dropSchemaWriter,
>                     getSession().getPlatform().getStoredProcedureTerminationToken());
784a788,791
>     }
>     
>     public void shouldCreateSQLFiles(boolean genFlag) {
>         this.createSQLFiles = genFlag;