dev@glassfish.java.net

Re: About GLASSFISH-20934

From: Tang Yong <tangyong_at_cn.fujitsu.com>
Date: Thu, 19 Dec 2013 11:44:39 +0900

David,

I have another thing and want to discuss with you:

in jms core, only ActiveJmsResourceAdapter class extends
ActiveInboundResourceAdapterImpl class and depeneds on
org.glassfish.main.connectors.inbound-runtime module.

1) considering in the future whether using interface or composite rather
than "extends"?

2) an interesting thing is that once jms core do not depened on
org.glassfish.main.connectors.inbound-runtime, this issue will not
happen. Of course, this is not issue's nature. :)

Thanks
Tang

David Zhao wrote:
> Hi Tang,
>
> JmsProviderLifecycle depends on ActiveJmsResourceAdapter, and ActiveJmsResourceAdapter depends on JMXStartupService. Because JMXStartupService is in PostStartupRunLevel, I am afraid of that promoting JmsProviderLifecycle to be StartupRunLevel is not feasible.
>
> Thanks,
> David Zhao
>
>> -----Original Message-----
>> From: Tang Yong [mailto:tangyong_at_cn.fujitsu.com]
>> Sent: Wednesday, December 18, 2013 5:23 PM
>> To: dev_at_glassfish.java.net
>> Cc: Sahoo; John Wells
>> Subject: About GLASSFISH-20934
>>
>> JMS)Leader
>> CC: Sahoo
>>
>> pl. allowing me open a new thread for GLASSFISH-20934.
>>
>> Firstly, I request you can see the issue. if having any issue, pl. tell
>> me and I will re-check my description.
>>
>> Secondly, about fixing way, I have a very simple method as following:
>>
>> [original definition]
>> @Service
>> @RunLevel(value=PostStartupRunLevel.VAL,
>> mode=RunLevel.RUNLEVEL_MODE_NON_VALIDATING)
>> public class JmsProviderLifecycle implements PostConstruct{ ...
>> }
>>
>> [my fixing way]
>> @Service
>> @RunLevel(value=StartupRunLevel.VAL,
>> mode=RunLevel.RUNLEVEL_MODE_NON_VALIDATING)
>> public class JmsProviderLifecycle implements PostConstruct{ ...
>> }
>>
>>
>> That is to say, making org.glassfish.main.jms.core can be started
>> earlier. Because this is also related to kernel starting, cc Sahoo for
>> evaluation.
>>
>> Thanks
>> Tang
>> --
>> ----------------------
>> Tang Yong
>> Senior Engineer
>> GlassFish Committer (OSGi & OSGi-JavaEE) OSGi Alliance Supporter
>> Blog: http://osgizone.typepad.com/tangyong/
>>
>> Nanjing Fujitsu NanDa Software Tec CO.,LTD
>> http://www.fujitsu.com/cn/fnst
>> Tel: +86-25-86630566-8310
>> Fax: +86-25-83317685
>> ----------------------
>>
>>
>
>

-- 
----------------------
Tang Yong
Senior Engineer
GlassFish Committer (OSGi & OSGi-JavaEE)
OSGi Alliance Supporter
Blog: http://osgizone.typepad.com/tangyong/
Nanjing Fujitsu NanDa Software Tec CO.,LTD
http://www.fujitsu.com/cn/fnst
Tel: +86-25-86630566-8310
Fax: +86-25-83317685              
----------------------