dev@glassfish.java.net

Re: pom.xml change for maven-embedded-glassfish-plugin

From: Bhavanishankar <bhavanishankara.sapaliga_at_oracle.com>
Date: Wed, 10 Apr 2013 20:35:18 +0530

Thanks Romain. So the changes willjust be :

Index: pom.xml
===================================================================
--- pom.xml (revision 61284)
+++ pom.xml (working copy)
@@ -141,7 +141,7 @@
      </dependency>

       <dependency>
- <groupId>org.glassfish</groupId>
+ <groupId>org.glassfish.main.common</groupId>
<artifactId>simple-glassfish-api</artifactId>
        <version>4.0-SNAPSHOT</version>
        <scope>compile</scope>

When the 4.0 final version of the plugin is released it can point to 4.0 version
of simple-glassfish-api and glassfish all-in-one jars.

For now, unless you have further concerns, I will go ahead with this change.

- Bhavani

On Wed 10 Apr 2013 02:40 PM, Romain Grecourt wrote:
> On 4/10/13 8:54 AM, Bhavanishankar wrote:
>> I need to make the following change to the pom.xml so that the plugin points
>> to the correct simple-glassfish-api artifact:
>>
>> Index: pom.xml
>> ===================================================================
>> --- pom.xml (revision 61284)
>> +++ pom.xml (working copy)
>> @@ -141,9 +141,9 @@
>> </dependency>
>>
>> <dependency>
>> - <groupId>org.glassfish</groupId>
>> + <groupId>org.glassfish.main.common</groupId>
>> <artifactId>simple-glassfish-api</artifactId>
>> - <version>4.0-SNAPSHOT</version>
>> + <version>4.0-b83</version>
>> <scope>compile</scope>
>> </dependency>
>> </dependencies>
>>
>> Ideally I should point it to 4.0-SNAPSHOT of simple-glassfish-api. But since
>> the repository does not contain 4.0-SNAPSHOT of simple-glassfish-api,
> It does, see
> https://maven.java.net/content/repositories/snapshots/org/glassfish/main/common/simple-glassfish-api/4.0-SNAPSHOT/
>> I need to make it point to b83
>> <https://maven.java.net/content/groups/promoted/org/glassfish/main/common/simple-glassfish-api/4.0-b83>.
>>
>> Please review.
> Ideally this plugin should be released at the same frequency as GlassFish and
> reference dependencies using its own version.
> I don't see the value of doing this change without making a release of the
> plugin, since it's currently only published as SNAPSHOT it can reference
> simple-glassfish-api:4.0-SNAPSHOT
>
> Thanks,
> Romain
>>
>> - Bhavani
>>
>