Shaun,
Please read and following the CCP here:
http://aseng-wiki.us.oracle.com/asengwiki/display/GlassFish/Java+EE+7+Bug+Triage+and+Fixing#JavaEE7BugTriageandFixing-4BugFixApprovalProcess%28ChangeControl%29
The text you have below goes in the bug itself. You should set the
4.0-review tag in the bug and then send an email with just the bug id.
I've marked the bug as approved for 4.0
Thanks.
Tom
On 4/3/13 10:18 AM, Shaun Pei wrote:
>
> Hi Michael and Tom
>
> Component Name: QL test/ Security/
>
> Issue: http://java.net/jira/browse/GLASSFISH-20151
>
> I need to submit a fix for Hudson Windows build failure.
>
> 1)What is the impact on the customer of the bug?
>
> N/A
>
> 2) What is the cost/risk of fixing the bug
>
> Minimum, to fix quicklook test
>
> 3) Is there an impact on documentation or message strings?
>
> None
>
> 4) Which tests should QA (re)run to verify the fix did not destabilize GlassFish?
> Quicklook test for all profiles
>
> 5) Which is the targeted build of 4.0 for this fix?
>
>
> 4.0b83
>
> 6) what are the changes that are being brought in
>
> In quicklook/build.xml, relocate test app 'appperms' deployment from
> "build-deploy" target to "build-deploy-gd" (similar for undeploy), and
> also remove my test from the testing/testng_debug.xml list since that
> depends on "build-deploy". In other word, the test will only deploy
> and run in testng_gd_security and testng_gd.
>
> I run following tests locally, and they are clean
>
> Glassfish Profile,
>
> Glassfish Profile with Security Manager Turned On,
>
> Web Profile,
>
> Web Profile with Security Manager Turned On
>
> Change details:
>
> --------------------------------------------------------------------------------------------------------------------------------------
>
> [spei_at_slc01fnc quicklook]$ svn diff
>
> Index: build.xml
>
> ===================================================================
>
> --- build.xml (revision 61113)
>
> +++ build.xml (working copy)
>
> @@ -245,7 +245,6 @@
>
> <ant dir="persistence/jpavalidation" target="build-deploy"/>
>
> <ant dir="security/helloworld" target="build-deploy"/>
>
> <ant dir="security/basicauth" target="build-deploy"/>
>
> - <ant dir="security/appperms" target="build-deploy"/>
>
> <ant dir="ejb/slsbnicmt" target="build-deploy"/>
>
> <ant dir="ejb/sfulnoi" target="build-deploy"/>
>
> <ant dir="bean-validator/simple-bv-servlet"
> target="build-deploy"/>
>
> @@ -268,6 +267,7 @@
>
> -->
>
> <ant dir="wsit/JaxwsFromWsdl" target="build-deploy"/>
>
> <ant dir="wsit/jaxbosgi" target="build-deploy"/>
>
> + <ant dir="security/appperms" target="build-deploy"/>
>
> </target>
>
> <target name="undeploy">
>
> @@ -280,7 +280,6 @@
>
> <ant dir="persistence/jpavalidation" target="undeploy"/>
>
> <ant dir="security/helloworld" target="undeploy"/>
>
> <ant dir="security/basicauth" target="undeploy"/>
>
> - <ant dir="security/appperms" target="undeploy"/>
>
> <ant dir="ejb/slsbnicmt" target="undeploy"/>
>
> <ant dir="ejb/sfulnoi" target="undeploy"/>
>
> <ant dir="bean-validator/simple-bv-servlet" target="undeploy"/>
>
> @@ -301,6 +300,7 @@
>
> -->
>
> <ant dir="wsit/JaxwsFromWsdl" target="undeploy"/>
>
> <ant dir="wsit/jaxbosgi" target="undeploy"/>
>
> + <ant dir="security/appperms" target="undeploy"/>
>
> </target>
>
> <!-- Target is re-definted here as didn't want to specify ws.root
> property -->
>
> Index: testng/testng_debug.xml
>
> ===================================================================
>
> --- testng/testng_debug.xml (revision 61113)
>
> +++ testng/testng_debug.xml (working copy)
>
> @@ -115,11 +115,6 @@
>
> <class name="test.security.basicauth.BasicAuthTestNG" />
>
> </classes>
>
> </test>
>
> - <test name="security_app_permissions">
>
> - <classes>
>
> - <class name="test.security.appperms.ApppermsTestNG" />
>
> - </classes>
>
> - </test>
>
> <!--<test name="ejb30_session_hello">
>
> <classes>
>
> <class name="ejb30.session.hello.test.TestClient" />
>
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Let me know if you have more question.
>
> Regards
>
> Shaun
>