Yes, you can make these changes to top level pom.xml, I already sent you approval yesterday so maybe you missed it.
Since you already made changes to samples project, you should also have permissions to update top level pom.xml. Could you please provide the exact error you are seeing?
Thanks,
Snjezana
----- Original Message -----
From: dapeng.hu_at_oracle.com
To: snjezana.sevozenzerovic_at_oracle.com, romain.grecourt_at_oracle.com
Cc: dev_at_glassfish.java.net
Sent: Friday, April 26, 2013 4:59:35 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna
Subject: RE: POM review request
Hi Snjezana:
Do you agree with the change for the top level javaee7/pom.xml?
BTW, it seems that javaee7 is locked. Do you know who can grant me authorization to submit code change?
Regards
Dapeng
From: Dapeng Hu
Sent: Thursday, April 25, 2013 10:46 AM
To: Snjezana Sevo-Zenzerovic; Romain Grecourt
Cc: dev_at_glassfish.java.net
Subject: RE: POM review request
Hi Snjezana:
After I reviewed other sub-modules for connector sample project, I found there are other plugins (e.g. maven-ear-plugin , maven-ejb-plugin …) which need define versions in the top-most pom.xml.
Here is the diff which contains new plugins. Please review it.
Index: pom.xml
===================================================================
--- pom.xml (revision 1133)
+++ pom.xml (working copy)
@@ -137,6 +137,36 @@
<artifactId>cargo-maven2-plugin</artifactId>
<version>1.3.2</version>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-jar-plugin</artifactId>
+ <version>2.4</version>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-rar-plugin</artifactId>
+ <version>2.3</version>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-ear-plugin</artifactId>
+ <version>2.8</version>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-ejb-plugin</artifactId>
+ <version>2.3</version>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <version>1.2</version>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-antrun-plugin</artifactId>
+ <version>1.7</version>
+ </plugin>
</plugins>
</pluginManagement>
<plugins>
Regards
Dapeng
From: Dapeng Hu
Sent: Thursday, April 25, 2013 9:01 AM
To: Snjezana Sevo-Zenzerovic; Romain Grecourt
Cc: dev_at_glassfish.java.net
Subject: RE: POM review request
Hi Snjezana:
As you suggested, I move plugin version definition to the pom.xml at javaee7 level. Here is the diff.
Index: pom.xml
===================================================================
--- pom.xml (revision 1133)
+++ pom.xml (working copy)
@@ -137,6 +137,16 @@
<artifactId>cargo-maven2-plugin</artifactId>
<version>1.3.2</version>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-jar-plugin</artifactId>
+ <version>2.4</version>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-rar-plugin</artifactId>
+ <version>2.3</version>
+ </plugin>
</plugins>
</pluginManagement>
<plugins>
Regards
Dapeng
From: Snjezana Sevo-Zenzerovic
Sent: Wednesday, April 24, 2013 10:57 PM
To: Romain Grecourt
Cc: Dapeng Hu; Jagadish Ramu; as_dev_ww_grp
Subject: Re: POM review request
FWIW, I will review all sample project POMs this week and either cleanup or flag hard-coded versions, among other things. Since there is an existing pluginManagement section in the top level javaee7/pom.xml, please define those plugins and their version there and then just keep plugin reference in the module pom.xml as suggested by Romain.
Thanks,
Snjezana
----- Original Message -----
From: romain.grecourt_at_oracle.com
To: dapeng.hu_at_oracle.com
Cc: "as_dev_ww_grp" < as_dev_ww_grp_at_oracle.com >, jagadish.ramu_at_oracle.com
Sent: Wednesday, April 24, 2013 11:03:29 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna
Subject: Re: POM review request
Hi Dapeng,
*please* use gf-build_us_at_oracle.com or dev_at_glassfish.java.net
So far I did not review anything from the samples workspace.
Note that hard-coded plugin version is not a very good practice. It should instead go into the pluginManagement section of the relevant parent pom.
Thanks,
Romain
On 4/24/13 9:30 AM, Dapeng Hu wrote:
Hi Romain:
Could you review the change for JavaEE 7.0 sample project for connectors?
Index: javaee7/connectors/mailconnector/mailconnector-ra/pom.xml
===================================================================
--- javaee7/connectors/mailconnector/mailconnector-ra/pom.xml (revision 1133)
+++ javaee7/connectors/mailconnector/mailconnector-ra/pom.xml (working copy)
@@ -71,6 +71,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
+ <version>2.4</version>
<configuration>
<classifier>lib</classifier>
</configuration>
@@ -86,6 +87,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-rar-plugin</artifactId>
+ <version>2.3</version>
<configuration>
<finalName>mailconnector</finalName>
<rarSourceDirectory>${basedir}/target/classes</rarSourceDirectory>
cid:CDF643B8-3803-4A72-AB35-BE2FD51C3CDC
Dapeng Hu | Senior Techinical Staff | 86-10-61065511
Oracle Weblogic Server Development
Oracle Building | Zhongguanchun Software Park | Bejing, 100193, P.R.C