Romain,
I'll change the apiPackage back to the following (I wasn't sure if this was intended to reflect the artifactid or not).
<spec>
<apiPackage>javax.persistence</apiPackage>
I can also update the spec version to reflect that this is version "2.0.113"
Does that address your concerns? The groupId for javax.persistence has always been "org.eclipse.persistence", so wouldn't anticipate that changing?
Regards,
David
From: Romain Grecourt
Sent: April-18-13 2:41 PM
To: David Twelves
Cc: as_dev_ww_grp; Peter Krogh; Eric Gwin; Mitesh Meswani; Bill Shannon
Subject: Re: pom.xml review request for EclipseLink update
Please use HYPERLINK "mailto:gf-build_us_at_oracle.com"gf-build_us_at_oracle.com or HYPERLINK "mailto:dev_at_glassfish.java.net"dev_at_glassfish.java.net for pom reviews.
The maven versioning document written by Bill enforces some things that are not respected. (
https://wikis.oracle.com/display/GlassFish/Maven+Versioning+Rules)
The apiPackage of javax.persistence is "javax.persistence".
The coordinates of an API artifact should be apiPackage:apiPackage-api (groupId:artifactId).
According to the maven version (2.5.0-M13), the specBuild is 13.
Bill, should we allow those changes ?
Thanks,
Romain
On 18/04/2013 20:04, David Twelves wrote:
Review request: appserver/pom.xml changes for upgrading EclipseLink.
EclipseLink 2.5.0-M12 -> 2.5.0-M13
javax.persistence artifact id change, to "javax.persistence-api"
Following pom.xml files also needed updating to reflect artifact id change
appserver/pom.xml
appserver/deployment/schemas/pom.xml
appserver/deployment/dol/pom.xml
appserver/javaee-api/javax.javaee-web-api/pom.xml
appserver/transaction/jta/pom.xml
appserver/transaction/internal-api/pom.xml
appserver/packager/glassfish-common-web/pom.xml
Tests run:
Quicklook
SQE JPA test suite
Triaging 6 test case failures, will not commit until these are understood.
EJB Cluster test suite
Index: appserver/pom.xml
===================================================================
--- appserver/pom.xml (revision 61468)
+++ appserver/pom.xml (working copy)
@@ -109,8 +109,8 @@
<jaxb.version>2.2.7-b63</jaxb.version>
<stax2-api.version>3.1.1</stax2-api.version>
<javax.xml.registry-api.version>1.0.4</javax.xml.registry-api.version>
- <eclipselink.version>2.5.0-M12</eclipselink.version>
- <javax-persistence-api.version>2.1.0-M12</javax-persistence-api.version>
+ <eclipselink.version>2.5.0-M13</eclipselink.version>
+ <javax-persistence-api.version>2.1.0-M13</javax-persistence-api.version>
<dbschema.version>3.1.1</dbschema.version>
<dbschema.osgi.version>6.0</dbschema.osgi.version>
<schema2beans.version>3.1.1</schema2beans.version>
@@ -364,7 +364,7 @@
<spec>
<artifact>
<groupId>org.eclipse.persistence</groupId>
- <artifactId>javax.persistence</artifactId>
+ <artifactId>javax.persistence-api</artifactId>
<version>2.0.110-SNAPSHOT</version>
</artifact>
<nonFinal>true</nonFinal>
@@ -372,7 +372,7 @@
<specVersion>2.0</specVersion>
<newSpecVersion>2.1</newSpecVersion>
<specBuild>10</specBuild>
- <apiPackage>javax.persistence</apiPackage>
+ <apiPackage>javax.persistence-api</apiPackage>
</spec>
<spec>
<artifact>
@@ -563,7 +563,7 @@
</dependency>
<dependency>
<groupId>org.eclipse.persistence</groupId>
- <artifactId>javax.persistence</artifactId>
+ <artifactId>javax.persistence-api</artifactId>
<version>${javax-persistence-api.version}</version>
</dependency>
<dependency>
Regards,
David