dev@glassfish.java.net

Re: pom.xml review (web/*)

From: Romain Grecourt <romain.grecourt_at_oracle.com>
Date: Thu, 25 Oct 2012 22:38:15 +0200

Hi Amy,

Looks fine.

Thanks,
Romain

On 10/25/2012 10:37 PM, Amy Roh wrote:
> Hi,
>
> Please review this change which is required for logging migration for
> web/* modules.
>
> Thanks,
> Amy
>
> Index: web/admin/pom.xml
> ===================================================================
> --- web/admin/pom.xml (revision 56703)
> +++ web/admin/pom.xml (working copy)
> @@ -205,6 +205,11 @@
> <artifactId>amx-javaee</artifactId>
> <version>${project.parent.version}</version>
> </dependency>
> + <dependency>
> + <groupId>org.glassfish.annotations</groupId>
> + <artifactId>logging-annotation-processor</artifactId>
> + <optional>true</optional>
> + </dependency>
> </dependencies>
> </project>
>
> Index: web/jsf-connector/pom.xml
> ===================================================================
> --- web/jsf-connector/pom.xml (revision 56703)
> +++ web/jsf-connector/pom.xml (working copy)
> @@ -102,6 +102,11 @@
> <artifactId>dol</artifactId>
> <version>${project.version}</version>
> </dependency>
> + <dependency>
> + <groupId>org.glassfish.annotations</groupId>
> + <artifactId>logging-annotation-processor</artifactId>
> + <optional>true</optional>
> + </dependency>
> </dependencies>
> </project>
>
> Index: web/jspcaching-connector/pom.xml
> ===================================================================
> --- web/jspcaching-connector/pom.xml (revision 56703)
> +++ web/jspcaching-connector/pom.xml (working copy)
> @@ -94,6 +94,11 @@
> <artifactId>common-util</artifactId>
> <version>${project.version}</version>
> </dependency>
> + <dependency>
> + <groupId>org.glassfish.annotations</groupId>
> + <artifactId>logging-annotation-processor</artifactId>
> + <optional>true</optional>
> + </dependency>
> </dependencies>
> </project>
>
> Index: web/jstl-connector/pom.xml
> ===================================================================
> --- web/jstl-connector/pom.xml (revision 56703)
> +++ web/jstl-connector/pom.xml (working copy)
> @@ -88,6 +88,11 @@
> <artifactId>common-util</artifactId>
> <version>${project.version}</version>
> </dependency>
> + <dependency>
> + <groupId>org.glassfish.annotations</groupId>
> + <artifactId>logging-annotation-processor</artifactId>
> + <optional>true</optional>
> + </dependency>
> </dependencies>
> </project>
>
>
> On 10/24/12 10:41 AM, Romain Grecourt wrote:
>> Hi Amy,
>>
>> Looks fine.
>>
>> Thanks,
>> Romain
>>
>> On 10/24/2012 07:24 PM, Amy Roh wrote:
>>> Hi,
>>>
>>> Please review this pom.xml change which is required for logging
>>> migration for war-util module.
>>>
>>> Thanks,
>>> Amy
>>>
>>> Index: appserver/web/war-util/pom.xml
>>> ===================================================================
>>> --- appserver/web/war-util/pom.xml (revision 56703)
>>> +++ appserver/web/war-util/pom.xml (working copy)
>>> @@ -113,5 +113,10 @@
>>> <artifactId>glassfish-ee-api</artifactId>
>>> <version>${project.version}</version>
>>> </dependency>
>>> + <dependency>
>>> + <groupId>org.glassfish.annotations</groupId>
>>> + <artifactId>logging-annotation-processor</artifactId>
>>> + <optional>true</optional>
>>> + </dependency>
>>> </dependencies>
>>> </project>
>