Re: About GLASSFISH-18370
Hi sahoo,siva,
> Your change looks good to me. Let's wait for Siva to review as well.
> Siva had earlier mentioned that he would get back with his review
> comments by beginning of coming week, so give him time.
OK.
>
> I would request you to update the JIRA with github URL and use JIRA to
> communicate about contributions related to issues. It's easier to
> maintain that way.
I will do it.
--Tang
>
> On Friday 20 July 2012 11:45 AM, Tang Yong wrote:
>> Dear Sahoo, Sivakumar
>>
>> About GLASSFISH-18370(http://java.net/jira/browse/GLASSFISH-18370),
>>
>> I have finished the investigation and made a revise which is on
>> https://github.com/tangyong/GLASSFISH-18370.
>>
>> I modifed the stockquote-cdi-osgi-sample and can trigger the
>> UndeclaredThrowableException, you can get the sample from the above
>> github url.
>>
>> Just as aaronjwhiteside said: we really need to get the cause of
>> InvocationTargetException, otherwise, once InvocationTargetException
>> happened, UndeclaredThrowableException will be thrown by a method
>> invocation on a proxy instance[1].
>>
>> [1]: About "UndeclaredThrowableException"
>> http://docs.oracle.com/javase/6/docs/api/java/lang/reflect/UndeclaredThrowableException.html
>>
>> In addition, besides
>> org.glassfish.osgicdi.impl.OSGiServiceFactory$DynamicInvocationHandler.invoke
>> method,
>> org.glassfish.osgicdi.impl.OSGiServiceFactory$StaticInvocationHandler.invoke
>> method should be also revised when not using "dynamic = true".
>>
>>> sahoo
>> If you have more time, please review my revise. I will continue to
>> investigate the next topic.
>>
>> Thanks aaronjwhiteside too !
>>
>> --Best Regard!
>> --Tang
>>
>>
>>
>>
>>
>
>
>