On 6/4/12 5:19 PM, Tim Quinn wrote:
> On Jun 4, 2012, at 9:49 AM, Romain Grecourt wrote:
>
>> Hi Tim,
>>
>> The scope "optional" will make the security-services dependency invisible for module that depend on admin/util.
>> Did you check if the new artifact is correctly packaged ? If the artifact is not packaged correctly then you might need to remove the optional scope.
>>
> This was patterned after the dependency on the security/core module. But the usage is different so the scope should not be provided.
>
> I've changed it and am retesting but I expect the tests will be fine.
My mistake, your changes are fine... I mixed up <scope>provided</scope>
and <optional>true<optional>.
Thanks,
Romain
>
> Thanks.
>
> - Tim
>
>> Thanks,
>> Romain
>>
>>
>> On 6/4/12 4:22 PM, Tim Quinn wrote:
>>> Please review these changes.
>>>
>>> The new security authentication service resides in a new module. The pom.xml change adds this module to the dependencies for admin/util.
>>>
>>> As part of this conversion I've added uses of the PasswordCredential class in a package that was not previous imported into admin/util, hence the osgi.bundle change.
>>>
>>> Thanks.
>>>
>>> - Tim
>>>
>>> Index: pom.xml
>>> ===================================================================
>>> --- pom.xml (revision 54409)
>>> +++ pom.xml (working copy)
>>> @@ -141,6 +141,12 @@
>>> <scope>provided</scope>
>>> </dependency>
>>> <dependency>
>>> +<groupId>org.glassfish.main.security</groupId>
>>> +<artifactId>security-services</artifactId>
>>> +<version>${project.parent.version}</version>
>>> +<scope>provided</scope>
>>> +</dependency>
>>> +<dependency>
>>> <groupId>org.glassfish.main.tests</groupId>
>>> <artifactId>utils</artifactId>
>>> <version>${project.version}</version>
>>> tjquinn-mac:util tjquinn$ svn diff osgi.bundle
>>> Index: osgi.bundle
>>> ===================================================================
>>> --- osgi.bundle (revision 54409)
>>> +++ osgi.bundle (working copy)
>>> @@ -47,4 +47,5 @@
>>> com.sun.enterprise.admin.util.proxy; \
>>> com.sun.enterprise.admin.util.test; version=${project.osgi.version}
>>> DynamicImport-Package: \
>>> - com.sun.enterprise.security.ssl
>>> + com.sun.enterprise.security.ssl; \
>>> + com.sun.enterprise.security.auth.login