dev@glassfish.java.net

Re: pom.xml/osgi.bundle review request for nucleus/admin/util

From: Tim Quinn <tim.quinn_at_oracle.com>
Date: Mon, 4 Jun 2012 09:40:27 -0500

On Jun 4, 2012, at 9:38 AM, Sahoo wrote:

> Tim,
>
> What's the dynamic import for?

Actually, that change was left over from some earlier work that turned out not to be needed. I've removed that change.

Thanks for catching it.

- Tim

>
> Thanks,
> Sahoo
> On Monday 04 June 2012 07:52 PM, Tim Quinn wrote:
>> Please review these changes.
>>
>> The new security authentication service resides in a new module. The pom.xml change adds this module to the dependencies for admin/util.
>>
>> As part of this conversion I've added uses of the PasswordCredential class in a package that was not previous imported into admin/util, hence the osgi.bundle change.
>>
>> Thanks.
>>
>> - Tim
>>
>> Index: pom.xml
>> ===================================================================
>> --- pom.xml (revision 54409)
>> +++ pom.xml (working copy)
>> @@ -141,6 +141,12 @@
>> <scope>provided</scope>
>> </dependency>
>> <dependency>
>> +<groupId>org.glassfish.main.security</groupId>
>> +<artifactId>security-services</artifactId>
>> +<version>${project.parent.version}</version>
>> +<scope>provided</scope>
>> +</dependency>
>> +<dependency>
>> <groupId>org.glassfish.main.tests</groupId>
>> <artifactId>utils</artifactId>
>> <version>${project.version}</version>
>> tjquinn-mac:util tjquinn$ svn diff osgi.bundle
>> Index: osgi.bundle
>> ===================================================================
>> --- osgi.bundle (revision 54409)
>> +++ osgi.bundle (working copy)
>> @@ -47,4 +47,5 @@
>> com.sun.enterprise.admin.util.proxy; \
>> com.sun.enterprise.admin.util.test; version=${project.osgi.version}
>> DynamicImport-Package: \
>> - com.sun.enterprise.security.ssl
>> + com.sun.enterprise.security.ssl; \
>> + com.sun.enterprise.security.auth.login
>