dev@glassfish.java.net

Re: Seeking Review: forward port javax.faces integration to trunk

From: Jason Lee <jason.d.lee_at_oracle.com>
Date: Thu, 08 Dec 2011 14:30:42 -0600

Ed and I worked through some issues and have both successfully built and
run the server and tests. The change looks good to me.

On 12/7/11 2:48 PM, Edward Burns wrote:
> Hello Team,
>
> My commit r49388 to the 3.1.2 branch changed the way GlassFish depends
> on, integrates and packages its JSF implementation such that one jar,
> javax.faces.jar, is used instead of two jars, jsf-api.jar and
> jsf-impl.jar.
>
> r49388 | edburns | 2011-09-09 14:48:45 -0400 (Fri, 09 Sep 2011) | 91 lines
>
> I have forward ported these changes to the trunk and ran a test build
> [1], as well as running quicklook [2]. The changes integrate the 2.1.6
> version of Mojarra.
>
> The diff is attached to the issue JAVASERVERFACES-2028 [3] and is
> essentially the same as I shared with this list in my review request on
> 8 Sepember 2011 [4].
>
> Can Jane or someone with similar authority please approve this?
>
> Thanks,
>
> Ed
>
> [1] http://adc2110030.us.oracle.com:7070/hudson/job/mojarra-MOJARRA_2_1X_ROLLING/149/
>
> [2] [echo] [testng] ===============================================
> [echo] [testng] QuickLookTests
> [echo] [testng] Total tests run: 107, Failures: 0, Skips: 0
> [echo] [testng] ===============================================
>
> [3] http://java.net/jira/browse/JAVASERVERFACES-2028
>
> [3] http://java.net/projects/glassfish/lists/dev/archive/2011-09/message/30


-- 
Jason Lee
Senior Member of Technical Staff, Oracle
GlassFish Team
Phone +1 (405) 216-3193
http://blogs.steeplesoft.com