Looks fine as far as packaging aspect is concerned...
Thanks,
Snjezana
----- Original Message -----
From: tom.mueller_at_oracle.com
To: dev_at_glassfish.java.net
Sent: Tuesday, November 15, 2011 1:26:53 PM GMT -08:00 US/Canada Pacific
Subject: pom.xml review request: security.jar
Please review the following pom.xml changes for reintroducing a
dependency from the admin/cli-optional, admin/cli, and admin/server-mgmt
modules onto the security.jar module. This dependency was removed in 3.1
for performance reasons, but now, to implement the secure by default
feature, we need it back. Performance testing is underway to assess
whether this causes a regression.
Thanks.
Tom
Index: admin/cli-optional/pom.xml
===================================================================
--- admin/cli-optional/pom.xml (revision 50874)
+++ admin/cli-optional/pom.xml (working copy)
@@ -214,5 +214,10 @@
<artifactId>backup</artifactId>
<version>${project.parent.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.glassfish.main.security</groupId>
+ <artifactId>security</artifactId>
+ <version>${project.version}</version>
+ </dependency>
</dependencies>
</project>
Index: admin/cli/pom.xml
===================================================================
--- admin/cli/pom.xml (revision 50874)
+++ admin/cli/pom.xml (working copy)
@@ -139,7 +139,7 @@
<mainClass>com.sun.enterprise.admin.cli.AsadminMain</mainClass>
</manifest>
<manifestEntries>
- <Class-Path>cli-optional.jar cluster-cli.jar glassfish.jar
server-mgmt.jar common-util.jar admin-util.jar launcher.jar backup.jar
admin-cli-l10n.jar glassfish-api.jar hk2.jar branding-fragment.jar
gms-adapter.jar</Class-Path>
+ <Class-Path>cli-optional.jar cluster-cli.jar glassfish.jar
server-mgmt.jar common-util.jar admin-util.jar launcher.jar backup.jar
admin-cli-l10n.jar glassfish-api.jar hk2.jar branding-fragment.jar
gms-adapter.jar security.jar</Class-Path>
<!-- 5776: we do not need backup jar entry, but I retain it, Kedar -->
</manifestEntries>
</archive>
@@ -224,6 +224,11 @@
<version>${project.parent.version}</version>
</dependency>
<dependency>
+ <groupId>org.glassfish.main.security</groupId>
+ <artifactId>security</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
<groupId>org.glassfish.hk2</groupId>
<artifactId>hk2</artifactId>
</dependency>
Index: admin/server-mgmt/pom.xml
===================================================================
--- admin/server-mgmt/pom.xml (revision 50874)
+++ admin/server-mgmt/pom.xml (working copy)
@@ -97,5 +97,10 @@
<artifactId>admin-util</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.glassfish.main.security</groupId>
+ <artifactId>security</artifactId>
+ <version>${project.version}</version>
+ </dependency>
</dependencies>
</project>