dev@glassfish.java.net

Re: Code review request: POM file changes to integrate the admingui/cluster module online help

From: Paul M Davies (Oracle) <"Paul>
Date: Thu, 18 Nov 2010 10:01:06 -0800

Hi Jane,

Done. Here are the results:

testng-summary:
     [echo] [testng]
     [echo] [testng] ===============================================
     [echo] [testng] QuickLookTests
     [echo] [testng] Total tests run: 127, Failures: 0, Skips: 0
     [echo] [testng] ===============================================
     [echo] [testng]


Is it OK for me to commit my changes now?

Regards,
-Paul

On 11/17/10 19:27, Jane Young wrote:
> Looks fine. Can you also run QL? Thanks.
>
> On 11/17/10 7:12 PM, Paul M Davies (Oracle) wrote:
>> Hi,
>>
>> To integrate the online help in the admingui/cluster/ module, I have
>> edited the following files in the v3 repo:
>>
>> * pom.xml
>> * packager/glassfish-cluster/pom.xml
>>
>> SVN diffs:
>>
>> Index: pom.xml
>> ===================================================================
>> --- pom.xml (revision 42911)
>> +++ pom.xml (working copy)
>> @@ -167,7 +167,7 @@
>> <findbugs.exclude></findbugs.exclude>
>> <btrace.version>1.0.5</btrace.version>
>> <opendmk.version>1.0-b01-ea</opendmk.version>
>> - <v3-docs.version>3.1-b04</v3-docs.version>
>> + <v3-docs.version>3.1-b05</v3-docs.version>
>> <l10n.version>3.0-b73</l10n.version>
>> <asm.version>3.1</asm.version>
>> <shoal.version>1.5.21</shoal.version>
>> @@ -1096,6 +1096,11 @@
>> </dependency>
>> <dependency>
>> <groupId>org.glassfish.admingui</groupId>
>> + <artifactId>console-cluster-plugin-help</artifactId>
>> + <version>${v3-docs.version}</version>
>> + </dependency>
>> + <dependency>
>> + <groupId>org.glassfish.admingui</groupId>
>> <artifactId>console-corba-plugin-help</artifactId>
>> <version>${v3-docs.version}</version>
>>
>> Index: packager/glassfish-cluster/pom.xml
>> ===================================================================
>> --- packager/glassfish-cluster/pom.xml (revision 42911)
>> +++ packager/glassfish-cluster/pom.xml (working copy)
>> @@ -88,6 +88,10 @@
>> <version>${project.version}</version>
>> </dependency>
>> <dependency>
>> + <groupId>org.glassfish.admingui</groupId>
>> + <artifactId>console-cluster-plugin-help</artifactId>
>> + </dependency>
>> + <dependency>
>> <groupId>org.glassfish.cluster</groupId>
>> <artifactId>cluster-admin</artifactId>
>> <version>${project.version}</version>
>>
>> Tests that I ran:
>>
>> 1. mvn clean install: build successful
>> 2. find glassfish/modules -name console-cluster-plugin-help.jar:
>> JAR file present as expected
>> 3. asadmin start-domain: domain started successfully
>> 4. Spot check online help for cluster-related Administration
>> Console pages: help page correctly displayed.
>>
>> Thanks!
>>
>> --
>>
>>
>>
>> Oracle <http://www.oracle.com>
>> Paul Davies| Principal Technical Writer| +1.408.276.3413
>> Oracle GlassFish Server Documentation
>> 4140 Network Circle, Santa Clara CA 95054, USA
>>
>> Green Oracle <http://www.oracle.com/commitment> Oracle is committed
>> to developing practices and products that help protect the environment
>>
>>
>


-- 
Oracle <http://www.oracle.com>
Paul Davies| Principal Technical Writer| +1.408.276.3413
Oracle GlassFish Server Documentation
4140 Network Circle, Santa Clara CA 95054, USA
Green Oracle <http://www.oracle.com/commitment> 	Oracle is committed to 
developing practices and products that help protect the environment