The concept. When a use calls EmbeddedFileSystem.Builder.installRoot api
or pass "org.glassfish.ejb.embedded.glassfish.installation.root"
property to createEJBContainer call they are expected to point to
glassfish3/glassfish dir.
-marina
Tom Mueller wrote:
> This change is not related to the embedded api. What would change
> there?
> Tom
>
>
> On 10/15/2010 1:57 PM, Marina Vatkina wrote:
>> Do you plan to change embedded api as well?
>>
>> thanks,
>> -marina
>>
>> Tom Mueller wrote:
>>> This is intended to reduce confusion. After this change, all
>>> asadmin commands that take an installation directory (--installdir)
>>> will take the same value, i.e., the directory that contains (bin,
>>> glassfish, javadb, mq). This is the directory value that is entered
>>> into the installer. If using the .zip file, it is the
>>> "..../glassfish3" directory.
>>>
>>> Tom
>>>
>>>
>>> On 10/15/2010 1:38 PM, Marina Vatkina wrote:
>>>> Joe Di Pol wrote:
>>>>> Marina Vatkina wrote:
>>>>>> Joe,
>>>>>>
>>>>>> Won't this be an incompatible change with all other references to
>>>>>> the install root?
>>>>>
>>>>> I'm not sure what you mean by "all other references".
>>>>>
>>>>> GlassFish has two concepts of an install location:
>>>>>
>>>>> com.sun.aas.installRoot # /opt/glassfish3/glassfish
>>>>> com.sun.aas.productRoot # /opt/glassfish3
>>>>
>>>> Embedded (both GF API and EJB embeddable container properties)
>>>> refer to the former.
>>>>>
>>>>> While the internals of GlassFish typically use the former, important
>>>>> end user interfaces, like the installer, use the later.
>>>>>
>>>>> For the *-node-* commands, including install-node, we have decided
>>>>> it makes the most sense to be consistent with the installer's
>>>>> concept of the "installation directory".
>>>>
>>>> Why do you need to use a name that is so close in its name to the
>>>> former but with the meaning of the latter?
>>>>>
>>>>> Note that this doesn't change the meaning of installRoot or
>>>>> any of the code that depends on that.
>>>>
>>>> It will introduce a lot of confusion.
>>>>
>>>> -marina
>>>>>
>>>>> Joe
>>>>>
>>>>>>
>>>>>> thanks,
>>>>>> -marina
>>>>>>
>>>>>> Joe Di Pol wrote:
>>>>>>>
>>>>>>> On Monday Oct 18th I will be checking in a fix for:
>>>>>>>
>>>>>>> 13834 create-node-*: --installdir should be changed to top level
>>>>>>> GF directory
>>>>>>>
>>>>>>> This fix will break compatibility with previous builds for the
>>>>>>> create-node-* and update-node-* commands (as well as domain.xml).
>>>>>>>
>>>>>>> These commands support the "--installdir" parameter to specify
>>>>>>> the location of a GlassFish installation. Currently it must
>>>>>>> point to the lower "glassfish" directory, as in
>>>>>>> /opt/glassfish3/glassfish. But after my fix it must point to
>>>>>>> the upper "glassfish3" directory. Before the change:
>>>>>>>
>>>>>>> create-node-ssh --nodehost myhost --installdir
>>>>>>> /opt/glassfish3/glassfish n1
>>>>>>>
>>>>>>> after the change:
>>>>>>>
>>>>>>> create-node-ssh --nodehost myhost --installdir /opt/glassfish3 n1
>>>>>>>
>>>>>>> This change breaks compatibility with earlier builds. Previous
>>>>>>> domain.xml files won't work. Any scripts or tests that use the
>>>>>>> "--installdir" option may need to be changed to remove the trailing
>>>>>>> "glassfish".
>>>>>>>
>>>>>>> I will be updating the admin CLI dev tests, and will run those and
>>>>>>> quicklook before checking in.
>>>>>>>
>>>>>>> Apologies for the inconvenience, but better that we fix this now
>>>>>>> while we can.
>>>>>>>
>>>>>>> Joe
>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>