No, the osgi.bundle changes look incorrect to me:
a) Why do you have to explicitly specify anything in the Import-Package
header?
b) Why do you have to export any package from this bundle?
Sahoo
On Friday 06 August 2010 11:03 PM, Bhakti Mehta wrote:
> Thanks Jane. Sahoo does the osgi.bundle change look ok?
>
> Jane Young wrote:
>> pom.xml file looks fine. Can someone else review the changes in
>> osgi.bundle?
>>
>> Thanks,
>> Jane
>>
>>
>> Bhakti Mehta wrote:
>>> Jane,
>>> This is for issue
>>> https://glassfish.dev.java.net/issues/show_bug.cgi?id=12738
>>> Please let me know if I can make these changes
>>>
>>> Regards,
>>> Bhakti
>>> Index: cluster/gms-adapter/osgi.bundle
>>> ===================================================================
>>> --- cluster/gms-adapter/osgi.bundle (revision 0)
>>> +++ cluster/gms-adapter/osgi.bundle (revision 0)
>>> @@ -0,0 +1,6 @@
>>> +-exportcontents: \
>>> + org.glassfish.gms, \
>>> + org.glassfish.gms.bootstrap.admin;
>>> version=${project.osgi.version}
>>> +Import-Package: \
>>> + com.sun.enterprise.config.serverbeans, \
>>> + *
>>> Index: cluster/gms-adapter/pom.xml
>>> ===================================================================
>>> --- cluster/gms-adapter/pom.xml (revision 39449)
>>> +++ cluster/gms-adapter/pom.xml (working copy)
>>> @@ -69,6 +69,12 @@
>>> <version>${project.version}</version>
>>> </dependency>
>>> <dependency>
>>> + <groupId>org.glassfish.admin</groupId>
>>> + <artifactId>config-api</artifactId>
>>> + <version>${project.version}</version>
>>> + </dependency>
>>> +
>>> + <dependency>
>>> <groupId>org.shoal</groupId>
>>> <artifactId>shoal-gms-api</artifactId>
>>> </dependency>
>>>
>>
>>