Looks fine from packaging point of view...
Thanks,
Snjezana
Hong Zhang wrote:
> Please review the pom.xml and osgi.bundle files for the
> deployment-common module. These changes are needed to add monitoring
> probes for the deployment.
> There is a new package org.glassfish.deployment.monitor added to the
> deployment-common module where the ProbeProvider and StatProvider
> classes live.
>
> Thanks,
>
> - Hong
>
> hzhang_at_nmr:~/files/workspaces/v3/deployment/common$ svn diff
> Index: osgi.bundle
> ===================================================================
> --- osgi.bundle (revision 40064)
> +++ osgi.bundle (working copy)
> @@ -42,8 +42,10 @@
> com.sun.enterprise.deploy.shared; \
> com.sun.enterprise.deployment.deploy.shared; \
> org.glassfish.loader.util; \
> - org.glassfish.deployment.common;
> version=${project.osgi.version}
> + org.glassfish.deployment.common; \
> + org.glassfish.deployment.monitor;
> version=${project.osgi.version}
>
> DynamicImport-Package: \
> + org.glassfish.flashlight.provider, \
> org.objectweb.asm;password=GlassFish, \
> org.objectweb.asm.commons;password=GlassFish
> Index: pom.xml
> ===================================================================
> --- pom.xml (revision 40064)
> +++ pom.xml (working copy)
> @@ -86,6 +86,19 @@
> </developer>
> </developers>
> <build>
> + <plugins>
> + <plugin>
> + <groupId>com.sun.enterprise</groupId>
> + <artifactId>hk2-maven-plugin</artifactId>
> + <configuration>
> + <archive>
> + <manifestEntries>
> +
> <probe-provider-class-names>org.glassfish.deployment.monitor.DeploymentLifecycleProbeProvider</probe-provider-class-names>
>
> + </manifestEntries>
> + </archive>
> + </configuration>
> + </plugin>
> + </plugins>
> </build>
> <dependencies>
> <dependency>
> @@ -103,6 +116,14 @@
> <version>${project.version}</version>
> </dependency>
> <dependency>
> + <groupId>org.glassfish.external</groupId>
> + <artifactId>management-api</artifactId>
> + </dependency>
> + <dependency>
> + <groupId>org.glassfish.gmbal</groupId>
> + <artifactId>gmbal</artifactId>
> + </dependency>
> + <dependency>
> <groupId>org.glassfish.common</groupId>
> <artifactId>common-util</artifactId>
> <version>${project.version}</version>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>
--
Oracle <http://www.oracle.com>
Snjezana Sevo-Zenzerovic
Green Oracle <http://www.oracle.com/commitment> Oracle is committed to
developing practices and products that help protect the environment