dev@glassfish.java.net

Re: osgi.bundle and pom.xml review request

From: Sanjeeb Sahoo <Sahoo_at_Sun.COM>
Date: Wed, 18 Aug 2010 16:32:09 +0530

Is it necessary to export com.sun.enterprise.resource.pool.monitor for
the probe providers of that package to be usable by monitoring
framework? Can you try without exporting and see if that's really the
case? If it is not needed, then don't export it. Otherwise, the changes
look good to me.

Sahoo

On Wednesday 18 August 2010 01:33 PM, Shalini Muthukrishnan wrote:
> Hi Sahoo, Jane,
>
> Please review the following changes to introduce monitoring statistics
> grouped by applications.
>
> Thanks,
> Shalini.
>
> Index: connectors/connectors-runtime/osgi.bundle
> ===================================================================
> --- connectors/connectors-runtime/osgi.bundle (revision 39861)
> +++ connectors/connectors-runtime/osgi.bundle (working copy)
> @@ -17,6 +17,7 @@
> com.sun.enterprise.resource.pool.datastructure;\
>
> com.sun.enterprise.resource.pool.datastructure.strategy;\
> com.sun.enterprise.resource.pool.resizer;\
> + com.sun.enterprise.resource.pool.monitor;\
> com.sun.enterprise.resource.pool.waitqueue;\
> com.sun.enterprise.resource.recovery;\
> com.sun.enterprise.resource.rm;\
>
> Index: connectors/connectors-runtime/pom.xml
> ===================================================================
> --- connectors/connectors-runtime/pom.xml (revision 39861)
> +++ connectors/connectors-runtime/pom.xml (working copy)
> @@ -42,7 +42,7 @@
> <configuration>
> <archive>
> <manifestEntries>
> -
> <probe-provider-class-names>com.sun.enterprise.resource.pool.monitor.JdbcConnPoolProbeProvider,com.sun.enterprise.resource.pool.monitor.ConnectorConnPoolProbeProvider</probe-provider-class-names>
>
> +
> <probe-provider-class-names>com.sun.enterprise.resource.pool.monitor.JdbcConnPoolProbeProvider,com.sun.enterprise.resource.pool.monitor.ConnectorConnPoolProbeProvider,com.sun.enterprise.resource.pool.monitor.JdbcConnPoolAppProbeProvider,com.sun.enterprise.resource.pool.monitor.ConnectorConnPoolAppProbeProvider</probe-provider-class-names>
>
> </manifestEntries>
> </archive>
> </configuration>
>