From: Jane Young <jane.young_at_oracle.com>
Date: Tue, 06 Jul 2010 13:33:08 -0700

Looks fine. Thanks.

Bobby Bissett wrote:
> Hi all (or Jane),
>
> This look ok? The upgrade tool doesn't need to be an OSGI jar file.
> The resulting manifest is below the changes.
>
> Thanks,
> Bobby
>
> hostname% svn diff extras
> Index: extras/upgrade/upgrade-jar/pom.xml
> ===================================================================
> --- extras/upgrade/upgrade-jar/pom.xml (revision 38378)
> +++ extras/upgrade/upgrade-jar/pom.xml (working copy)
> @@ -46,7 +46,7 @@
> </parent>
>
> <artifactId>upgrade-tool</artifactId>
> - <packaging>hk2-jar</packaging>
> + <packaging>jar</packaging>
> <name>Upgrade Tool</name>
>
> <build>
> @@ -54,16 +54,15 @@
> <resources>
> </resources>
> <plugins>
> - <plugin>
> - <groupId>com.sun.enterprise</groupId>
> - <artifactId>hk2-maven-plugin</artifactId>
> + <plugin>
> + <artifactId>maven-jar-plugin</artifactId>
> <configuration>
> <archive>
> <manifest>
>
> <mainClass>com.sun.enterprise.tools.upgrade.UpgradeToolMain</mainClass>
> </manifest>
> - <manifestEntries>
> - <Class-Path>common-util.jar javahelp.jar
> upgrade-branding.jar upgrade-tool-l10n.jar</Class-Path>
> + <manifestEntries>
> + <Class-Path>common-util.jar javahelp.jar
> upgrade-branding.jar upgrade-tool-l10n.jar</Class-Path>
> </manifestEntries>
> </archive>
> </configuration>
>
> And the newly created manifest:
>
> hostname% cat MANIFEST.MF
> Manifest-Version: 1.0
> Archiver-Version: Plexus Archiver
> Created-By: Apache Maven
> Built-By: bobby
> Build-Jdk: 1.6.0_20
> Main-Class: com.sun.enterprise.tools.upgrade.UpgradeToolMain
> Class-Path: common-util.jar javahelp.jar upgrade-branding.jar upgrade-
> tool-l10n.jar
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>