On 7/20/10 10:33 AM, Byron Nevins wrote:
> The tests are open-source and easy to find. and easy to not run as
> part of the build. I don't personally run unit tests, ever, for areas
> I'm not working on. There's no point because Hudson is running them
> all the time so i don't have to.
honestly that seem a very dangerous habit. unit tests are here to ensure
that side effects are not created, and side effect can show up anywhere...
if you consider some unit tests too slow or too close to your code that
random developers should not have to run them, I think they should be
moved to a different profile only you would run.
jerome
>
> It parses FIFTEEN different domain.xml files.
>
>
>
>
> On 7/20/2010 5:42 AM, Sanjeeb Sahoo wrote:
>> On Monday 19 July 2010 10:59 PM, Byron Nevins wrote:
>>>
>>>
>>> On 7/18/2010 11:30 PM, Jerome Dochez wrote:
>>>> On 7/18/10 8:01 PM, Byron Nevins wrote:
>>>>>
>>>>>
>>>>> On 7/18/2010 1:31 AM, Jerome Dochez wrote:
>>>>>> Byron
>>>>>>
>>>>>> I believe you added a test in common-util that fail when no
>>>>>> network connection is present.
>>>>>>
>>>>>> testEquals(com.sun.enterprise.util.net.NetUtilsTest)
>>>>>>
>>>>>> probably not a good idea to do :
>>>>>> assertTrue(NetUtils.isEqual("www.oracle.com",
>>>>>> "www.oracle.com"));
>>>>>> assertFalse(NetUtils.isEqual("oracle.com", "google.com"));
>>>>>>
>>>>>>
>>>>>> Can u fix this,
>>>>> Yes -- done.
>>>> thanks !
>>>>>
>>>>>
>>>>>> and also fix the test that slows down the entire build as
>>>>>> reported by Sahoo.
>>>>> No can do. I don't what test slows down his build.
>>>> I don't think it's particular to his build, mine is pretty slow
>>>> between those two outputs :
>>>>
>>> I've got 45 seconds with no VPN, 52 seconds with no internet
>>> connection.
>>> I can't reproduce any problem.
>> With the latest workspace which has revision 38801 [1], the time to
>> build/test common-util has drastically reduced. Now, it takes around
>> 45 seconds, out of which 37 seconds is spent in the test
>> MiniXmlParserTest. What is that test doing? Why is it taking so long?
>>
>> Thanks,
>> Sahoo
>>
>> [1] r38801 | bnevins | 2010-07-19 07:33:39 +0530 (Mon, 19 Jul 2010) |
>> 3 lines
>>
>> removed 2 tests that require an internet connection.
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>