dev@glassfish.java.net

Re: POM Change Review

From: Jerome Dochez <jerome.dochez_at_oracle.com>
Date: Thu, 15 Jul 2010 06:55:17 -0700

should it not be an internal-api module then ?

On 7/15/10 6:36 AM, Vijay Ramachandran wrote:
> On second thoughts, Target requires config/serverbeans stuff like
> Domain, Cluster, Server etc.
>
> I don't think we want to introduce this dependency in common-util,
> right ?
>
> Vijay
>
> On 7/15/10 12:47 AM, Jerome Dochez wrote:
>> same remark as last time, can this Target class be moved into a
>> common utility module rather than having the entire module set
>> importing admin-util ?
>>
>> On 7/14/10 1:40 PM, Jane Young wrote:
>>> Looks fine. Thanks.
>>>
>>>
>>> Amy Roh wrote:
>>>> This change is required to use com.sun.enterprise.admin.util.Target
>>>> utility class from core/kernel cli commands.
>>>>
>>>> Index: core/kernel/pom.xml
>>>> ===================================================================
>>>> --- core/kernel/pom.xml (revision 38584)
>>>> +++ core/kernel/pom.xml (working copy)
>>>> @@ -147,6 +147,11 @@
>>>> <version>${project.version}</version>
>>>> </dependency>
>>>> <dependency>
>>>> + <groupId>org.glassfish.admin</groupId>
>>>> + <artifactId>admin-util</artifactId>
>>>> + <version>${project.version}</version>
>>>> + </dependency>
>>>> + <dependency>
>>>> <groupId>com.sun.enterprise</groupId>
>>>> <artifactId>hk2</artifactId>
>>>> </dependency>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>