dev@glassfish.java.net

Re: POM Change Review Request

From: Jane Young <Jane.Young_at_Sun.COM>
Date: Mon, 10 May 2010 07:48:53 -0700

Can you change the profile name? "test" is too generic.

Also, you'll be changing the test to use embedded GF? If yes, then this
unit test will be changed to be in the build?
As I understand this, the prerequisite to run this test is GlassFish
installation.

Thanks,
Jane



Jason Lee wrote:
> Any thoughts on this change?
>
> On 5/5/10 4:18 PM, Jason Lee wrote:
>> It seems my change to move surefire's execution was insufficient.
>> The following change disables tests altogether, unless explicitly
>> enabled via the test profile. Any complaints?
>>
>> Index: pom.xml
>> ===================================================================
>> --- pom.xml (revision 36769)
>> +++ pom.xml (working copy)
>> @@ -131,19 +131,23 @@
>> <configuration>
>> <skip>true</skip>
>> </configuration>
>> - <executions>
>> - <execution>
>> - <id>surefire-it</id>
>> - <phase>integration-test</phase>
>> - <goals>
>> - <goal>test</goal>
>> - </goals>
>> + </plugin>
>> + </plugins>
>> + </build>
>> + <profiles>
>> + <profile>
>> + <id>test</id>
>> + <build>
>> + <plugins>
>> + <plugin>
>> + <groupId>org.apache.maven.plugins</groupId>
>> + <artifactId>maven-surefire-plugin</artifactId>
>> <configuration>
>> <skip>false</skip>
>> </configuration>
>> - </execution>
>> - </executions>
>> - </plugin>
>> - </plugins>
>> - </build>
>> + </plugin>
>> + </plugins>
>> + </build>
>> + </profile>
>> + </profiles>
>> </project>
>>
>
>
> ------------------------------------------------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net