dev@glassfish.java.net

Re: POM Change Review Request

From: Jason Lee <jason.d.lee_at_oracle.com>
Date: Mon, 10 May 2010 09:32:54 -0500

Any thoughts on this change?

On 5/5/10 4:18 PM, Jason Lee wrote:
> It seems my change to move surefire's execution was insufficient. The
> following change disables tests altogether, unless explicitly enabled
> via the test profile. Any complaints?
>
> Index: pom.xml
> ===================================================================
> --- pom.xml (revision 36769)
> +++ pom.xml (working copy)
> @@ -131,19 +131,23 @@
> <configuration>
> <skip>true</skip>
> </configuration>
> - <executions>
> - <execution>
> - <id>surefire-it</id>
> - <phase>integration-test</phase>
> - <goals>
> - <goal>test</goal>
> - </goals>
> + </plugin>
> + </plugins>
> + </build>
> + <profiles>
> + <profile>
> + <id>test</id>
> + <build>
> + <plugins>
> + <plugin>
> + <groupId>org.apache.maven.plugins</groupId>
> + <artifactId>maven-surefire-plugin</artifactId>
> <configuration>
> <skip>false</skip>
> </configuration>
> - </execution>
> - </executions>
> - </plugin>
> - </plugins>
> - </build>
> + </plugin>
> + </plugins>
> + </build>
> + </profile>
> + </profiles>
> </project>
>


-- 
Jason Lee
Senior Member of Technical Staff
GlassFish Administration Console
Oracle Corporation
Phone x31197/+1 405-343-1964
Blog http://blogs.steeplesoft.com