dev@glassfish.java.net

Re: POM Change Review Request

From: Jason Lee <jason.d.lee_at_oracle.com>
Date: Fri, 07 May 2010 13:55:05 -0500

Sorry. That's in v3/admin/rest/pom.xml

And, yes, the profile must be enabled to run the tests. These tests
require a running server, so we don't run them trying to execute during
a normal build cycle. At some point, I'm going to set up a Hudson job
to run these tests, which will, of course, enable the profile.

On 5/7/10 12:03 PM, Jane Young wrote:
> Which pom file? Doesn't look like v3/pom.xml.
> You're adding a new profile "test" and removing the integration-test
> from the regular build.
> Does that mean the test is only executed when building with "mvn
> -Ptest..." ? Who runs this test?
> Jane
>
>> Bump!
>>
>>
>>
>> On 5/5/10 4:18 PM, Jason Lee wrote:
>>> It seems my change to move surefire's execution was insufficient.
>>> The following change disables tests altogether, unless explicitly
>>> enabled via the test profile. Any complaints?
>>>
>>> Index: pom.xml
>>> ===================================================================
>>> --- pom.xml (revision 36769)
>>> +++ pom.xml (working copy)
>>> @@ -131,19 +131,23 @@
>>> <configuration>
>>> <skip>true</skip>
>>> </configuration>
>>> - <executions>
>>> - <execution>
>>> - <id>surefire-it</id>
>>> - <phase>integration-test</phase>
>>> - <goals>
>>> - <goal>test</goal>
>>> - </goals>
>>> + </plugin>
>>> + </plugins>
>>> + </build>
>>> + <profiles>
>>> + <profile>
>>> + <id>test</id>
>>> + <build>
>>> + <plugins>
>>> + <plugin>
>>> + <groupId>org.apache.maven.plugins</groupId>
>>> + <artifactId>maven-surefire-plugin</artifactId>
>>> <configuration>
>>> <skip>false</skip>
>>> </configuration>
>>> - </execution>
>>> - </executions>
>>> - </plugin>
>>> - </plugins>
>>> - </build>
>>> + </plugin>
>>> + </plugins>
>>> + </build>
>>> + </profile>
>>> + </profiles>
>>> </project>
>>>
>>
>>
>> ------------------------------------------------------------------------
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>


-- 
Jason Lee
Senior Member of Technical Staff
GlassFish Administration Console
Oracle Corporation
Phone x31197/+1 405-343-1964
Blog http://blogs.steeplesoft.com