dev@glassfish.java.net

Re: POM Change Review Request

From: Jane Young <Jane.Young_at_Sun.COM>
Date: Fri, 07 May 2010 10:03:46 -0700

Which pom file? Doesn't look like v3/pom.xml.
You're adding a new profile "test" and removing the integration-test
from the regular build.
Does that mean the test is only executed when building with "mvn
-Ptest..." ? Who runs this test?

Jane

> Bump!
>
>
>
> On 5/5/10 4:18 PM, Jason Lee wrote:
>> It seems my change to move surefire's execution was insufficient.
>> The following change disables tests altogether, unless explicitly
>> enabled via the test profile. Any complaints?
>>
>> Index: pom.xml
>> ===================================================================
>> --- pom.xml (revision 36769)
>> +++ pom.xml (working copy)
>> @@ -131,19 +131,23 @@
>> <configuration>
>> <skip>true</skip>
>> </configuration>
>> - <executions>
>> - <execution>
>> - <id>surefire-it</id>
>> - <phase>integration-test</phase>
>> - <goals>
>> - <goal>test</goal>
>> - </goals>
>> + </plugin>
>> + </plugins>
>> + </build>
>> + <profiles>
>> + <profile>
>> + <id>test</id>
>> + <build>
>> + <plugins>
>> + <plugin>
>> + <groupId>org.apache.maven.plugins</groupId>
>> + <artifactId>maven-surefire-plugin</artifactId>
>> <configuration>
>> <skip>false</skip>
>> </configuration>
>> - </execution>
>> - </executions>
>> - </plugin>
>> - </plugins>
>> - </build>
>> + </plugin>
>> + </plugins>
>> + </build>
>> + </profile>
>> + </profiles>
>> </project>
>>
>
>
> ------------------------------------------------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net