dev@glassfish.java.net

Re: ServerEnvironment.getDomainRoot() vs. ServerEnvironment.getInstanceRoot()

From: Byron Nevins <byron.nevins_at_oracle.com>
Date: Sun, 16 May 2010 21:35:18 -0700

It's @Deprecated now.



On 5/15/2010 12:25 AM, Bill Shannon wrote:
> If the consensus is that getDomainRoot should never have existed,
> maybe someone who loves the refactoring support in their IDE can
> fix it?
>
> Or, add @deprecated and let people fix it over time?
>
>
> Byron Nevins wrote on 05/14/2010 05:42 PM:
>> @Override
>> public File getDomainRoot() {
>> return getInstanceRoot();
>>
>> On 5/14/2010 5:08 PM, Bill Shannon wrote:
>>> Can someone tell me what the intended semantic difference is between
>>> ServerEnvironment.getDomainRoot() and
>>> ServerEnvironment.getInstanceRoot()?
>> getDomainRoot should have never existed. It makes no sense for
>> non-DAS servers to know DAS' root-dir. getInstanceRoot () makes
>> sense for any GF server.
>>
>> getDomainRoot is used in 105 java files unfortunately. I attached
>> the list FYI
>>
>>> Right now they both return the same value, at least for the DAS.
>>> Would they return different values in a server instance?
>> No -- both methods always return the same thing.
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>>
>> ------------------------------------------------------------------------
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>

-- 
Byron Nevins  -  Oracle Corporation
Home: 650-359-1290
Cell: 650-784-4123
Sierra: 209-295-2188