Hi Sekhar,
I'm not sure how much effort it requires, but could you upload a new
version of the output file again?
Carla fixed a number of issues in monitor and I fixed a number of issues
with broken messages/IDs in various modules.
Your output file can verify we did not miss any of the issues we
intended to fix.
That said, a number of issues will still show up:
- various unused messages or messages with FINE level (we need a good
strategy to address these, or filter them out)
- jdbc messages with no ID (could not get my patch approved)
- messages that intentionally have no ID
Thanks,
Dies
Sekhar Vajjhala wrote:
> I have uploaded a newer version of the output file containing missing
> message IDS.
> There are now two versions: using green-red color [1] , using
> gray-black color [2]
> to address color vision issues. I added links to both of these versions on
> the serviceability page [3] .
>
> Based on the email discussion:
> - I removed target directory ( the tool used to look in both source and
> target directories)
> - I added included both LogStrings.properties files and Bundle.properties
> (I was told there might be some messages in Bundle.properties with
> missing message IDS).
> - the tool cannot determine (at least for now) whether a message
> *should* have a message ID.
> So, for now, a message marked with a missing / incorrect message ID
> will need further manual
> evaluation to determine if a message ID is really required or not.
>
> [1]
> http://wiki.glassfish.java.net/attach/GlassFishV3LoggingServiceability/msgidlist.html
>
> [2]
> http://wiki.glassfish.java.net/attach/GlassFishV3LoggingServiceability/msgidlist-gray.html
>
> [3]
> http://wiki.glassfish.java.net/Wiki.jsp?page=GlassFishV3LoggingServiceability
>
>
> Sekhar Vajjhala
>
> Chandrasekhar Vajjhala wrote:
>> Hi,
>>
>> To assist in locating and fixing messages with missing message ID, I
>> wrote
>> a tool. I ran the tool against the LogStrings.properties files in the
>> GlassFish V3 workspace,
>> and uploaded the output to GlassFish wiki page at [1] . I also linked
>> [1] off the
>> GlassFish Serviceability page [2] .
>>
>> Take a look at the the summary at the top of [1] for information on
>> locating messages that need
>> to be fixed, statistics on files, messages etc.
>>
>> Note:
>> a. My workspace is about a couple of weeks old.
>> b. I will rerun the tool periodically for now.
>> c. I am looking into integrating the tool into GlassFish v3 build
>> using maven.
>>
>> Sekhar
>>
>> [1]
>> http://wiki.glassfish.java.net/attach/GlassFishV3LoggingServiceability/LogStrings-msgidlist.html?version=3
>>
>> [2]
>> http://wiki.glassfish.java.net/Wiki.jsp?page=GlassFishV3LoggingServiceability