dev@glassfish.java.net

Re: Please review pom.xml files

From: Ken Paulsen <Ken.Paulsen_at_Sun.COM>
Date: Mon, 09 Nov 2009 15:15:00 -0800

No there are not others at the moment. See my reply to Paul. I feel it
better to follow the maven recommendations and leave our options open in
the future vs. using Strings that are more limiting. I don't think
there are any current problems, however.

Thanks!

Ken

Jane Young wrote:
> Hi Ken,
>
> GlassFish v3 workspace has been using the format 3.0-b## for a
> while. What do you mean by not accurately comparing the version? We
> try to avoid version range in v3 pom.xml. Are there other pom.xml
> file that may depend on v3-docs artifacts?
> Jane
>
>
> Ken Paulsen wrote:
>>
>> Sorry! I hadn't noticed this until now :-( -- and apparently it
>> slipped by others as well. My preference would be to change it now,
>> I don't think it will be easier in the future.
>>
>> Ken
>>
>> Kim Haase wrote:
>>> This is Paul's area, not mine. It's a bit late to change the name
>>> now. I wish you had raised this issue a good deal earlier, before we
>>> had already had b01 through b06. Could we consider it after HCF?
>>>
>>> Thanks,
>>> Kim
>>>
>>> On 11/09/09 17:28, Ken Paulsen wrote:
>>>>
>>>> Hi Kim,
>>>>
>>>> I am not a fan of how you are naming the versions, please see:
>>>>
>>>>
>>>> http://docs.codehaus.org/display/MAVEN/Dependency+Mediation+and+Conflict+Resolution
>>>>
>>>>
>>>> Because of how you are specifying your version numbers, maven will
>>>> not be able to accurately compare them to determine the
>>>> oldest/newest version. I would suggest:
>>>>
>>>> 3.0.0-6
>>>>
>>>> Thanks!
>>>>
>>>> Ken
>>>>
>>>> Kim Haase wrote:
>>>>> Please review the following pom.xml changes needed to bump the
>>>>> version number for the v3-docs and to correct the name of the help
>>>>> artifact for JavaMail/JNDI.
>>>>>
>>>>> Thanks very much.
>>>>>
>>>>> Kim Haase
>>>>>
>>>>> Index: pom.xml
>>>>> ===================================================================
>>>>> --- pom.xml (revision 33922)
>>>>> +++ pom.xml (working copy)
>>>>> @@ -158,7 +158,7 @@
>>>>> <findbugs.exclude></findbugs.exclude>
>>>>> <btrace.version>1.0.5</btrace.version>
>>>>> <opendmk.version>1.0-b01-ea</opendmk.version>
>>>>> - <v3-docs.version>3.0-b05</v3-docs.version>
>>>>> + <v3-docs.version>3.0-b06</v3-docs.version>
>>>>> <l10n.version>3.0-b70</l10n.version>
>>>>> </properties>
>>>>>
>>>>> @@ -1032,7 +1032,7 @@
>>>>> </dependency>
>>>>> <dependency>
>>>>> <groupId>org.glassfish.admingui</groupId>
>>>>> - <artifactId>console-jmail-plugin-help</artifactId>
>>>>> +
>>>>> <artifactId>console-common-full-plugin-help</artifactId>
>>>>> <version>${v3-docs.version}</version>
>>>>> </dependency>
>>>>> <dependency>
>>>>> Index: packager/glassfish-common-full/pom.xml
>>>>> ===================================================================
>>>>> --- packager/glassfish-common-full/pom.xml (revision 33939)
>>>>> +++ packager/glassfish-common-full/pom.xml (working copy)
>>>>> @@ -106,7 +106,7 @@
>>>>> </dependency>
>>>>> <dependency>
>>>>> <groupId>org.glassfish.admingui</groupId>
>>>>> - <artifactId>console-jmail-plugin-help</artifactId>
>>>>> + <artifactId>console-common-full-plugin-help</artifactId>
>>>>> </dependency>
>>>>> <!-- now, listing package dependencies so that their content
>>>>> can be excluded during staging -->
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>