Inline,
Sahoo wrote:
> Nithya,
>
> 1. <version>${mail.version}</version> still apears in some places.
> e.g., javaee-api/javax.javaee/compact/pom.xml. Why?
I had missed the ${mail.version} in
javaee-api/javax.javaee/compact/pom.xml in my original pass. It's been
removed now.
>
> 2. I see mail version hardcoded in javadoc.xml. Why can't it use
> ${mail.version}? Ask Jane to see if she can help you avoiding this
> duplication.
The javadoc.xml does not inherit properties defined in the v3/pom.xml I
will talk to Jane regarding reducing this duplication. Looking at the
javadoc.xml, this seems to apply to most of the modules there.
>
> 3. You are removing javaee-api/javax.mail directory completely, right?
Yes.
I also noticed a replaced a reference to javax.mail.jar with mail.jar in
v3/extras/javaee/manifest-jar/src/main/resources/META-INF/MANIFEST.MF
Attached the diff file. The build & QL passed.
- Nitya
>
> Thanks,
> Sahoo
>
> Nitya Doraisamy wrote:
>> Jane
>> Thanks for the comments. I made the suggested changes. Removed
>> <version>${mail.version}</version> from
>> javaee-api/javax.javaee/pom.xml, web/web-naming/pom.xml,
>> common/container-common/pom.xml.
>> Attached updated diff.
>>
>> The javax.mail:mail:1.4.3-rc1 artifact gets bundled via the
>> 'container-common' package maven transitive dependency.
>>
>> Nitya
>>
>> Jane Young wrote:
>>> Comments:
>>>
>>> In javaee-api/javax.javaee/pom.xml, web/web-naming/pom.xml,
>>> common/container-common/pom.xml remove
>>> <version>${mail.version}</version> since you have it defined in
>>> dependencyManagement in v3/pom.xml
>>>
>>> Remove javaee-api/javax.mail directory (svn delete ...)
>>>
>>> How does javax.mail:mail:1.4.3-rc1 artifact gets bundled in packager
>>> ? If by Maven transitive dependency then which package?
>>>
>>> Thanks,
>>> Jane
>>>
>>>
>>> Nitya Doraisamy wrote:
>>>> Please review and approve the following changes to integrate
>>>> JavaMail 1.4.3-rc1 and remove redundant OSGi repackaging
>>>>
>>>> Thanks
>>>> Nitya
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>>