Yes.
I will also remove org.glassfish.common:glassfish-api in
dependencyManagement.
Thanks,
Jane
Mahesh Kannan wrote:
> Jane Young wrote:
>> Hi Mahesh,
>>
>> Since org.glassfish.orb:orb-connector and
>> org.glassfish.admin:config-api, org.glassfish.core:kernel and
>> org.glassfish.tests:utils are built in the same project, it should be
>> fine to specify <version>${project.version}</version>.
>>
>> The purpose of using the dependencyManagement is so that v3 modules
>> reference the same version of the external artifacts. The external
>> dependencies are centralized in one pom.xml. For example, we don't
>> want dependencies of different verisions of Grizzly or other external
>> artifacts referenced in multiple pom.xml in v3 workspace since this
>> will create a havoc in packager figuring out which version of
>> artifact to bundle.
>>
>> If it's okay with you, I would like to remove these dependencies from
>> dependencyManagement.
> OK. Would you also add <version> elements to orb-connector/pom.xml?
>
> Thanks,
> --Mahesh
>
>>
>> Thanks,
>> Jane
>>
>>
>>
>> Mahesh Kannan wrote:
>>> Jerome I was just avoiding the need to specify the versions in the
>>> orb-connector/pom.xml. If we remove the entries from top level
>>> pom.xml then orb-connector/pom.xml must have the version elements.
>>>
>>> Thanks,
>>> --Mahesh
>>>
>>>
>>> Jerome Dochez wrote:
>>>> we should ask mahesh why he added those, it is incorrect but he was
>>>> maybe trying to solve something.
>>>>
>>>> jerome
>>>>
>>>> On Oct 29, 2009, at 4:23 PM, Jane Young wrote:
>>>>
>>>>> Not correct. I'll remove it from dependencyManagement.
>>>>> Thanks for pointing this out.
>>>>>
>>>>> Jane
>>>>>
>>>>>
>>>>>
>>>>> Snjezana Sevo-Zenzerovic wrote:
>>>>>> I currently see these dependencies listed in the
>>>>>> dependencyManagement section of top level pom.xml:
>>>>>>
>>>>>> <dependency>
>>>>>> <groupId>org.glassfish.admin</groupId>
>>>>>> <artifactId>config-api</artifactId>
>>>>>> <version>${project.version}</version>
>>>>>> </dependency>
>>>>>> <dependency>
>>>>>> <groupId>org.glassfish.core</groupId>
>>>>>> <artifactId>kernel</artifactId>
>>>>>> <version>${project.version}</version>
>>>>>> </dependency>
>>>>>> <dependency>
>>>>>> <groupId>org.glassfish.tests</groupId>
>>>>>> <artifactId>utils</artifactId>
>>>>>> <version>${project.version}</version>
>>>>>> </dependency>
>>>>>>
>>>>>> Is this correct given that at least kernel and congif-api
>>>>>> modules are built as part of the project itself?
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Snjezana
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>