dev@glassfish.java.net

Re: ACTION: Ken or Mahesh Seeking Review for 10030: _at_Resource and JSR-303

From: Ed Burns <Ed.Burns_at_Sun.COM>
Date: Wed, 21 Oct 2009 13:51:58 -0700

>>>>> On Wed, 14 Oct 2009 11:30:21 -0400, Kenneth Saks <Kenneth.Saks_at_Sun.COM> said:
>>>>>>> On Fri, 9 Oct 2009 11:17:37 -0700, Ed Burns <ed.burns_at_sun.com>

EB> https://glassfish.dev.java.net/issues/show_bug.cgi?id=10030
EB> Ken, I have some questions in the diffs attached to this bug. Can you
EB> please take a look when you have a chance?

EB> I'd like to check this work in in two stages: 1. make @Resource
EB> work. 2. Make the JNDI lookup work.

EB> I have stage 1 done.

EB> Stage 2 is done now also.

EB> Can either of you please review this so I can check it in and close
EB> this
EB> bug?

KS> Changes look good.

Finally, after three stages I'm ready to check this in. I've run
quicklook and the BV integration test and everything is ok, so I'm going
to check it in.

Issue: 10030

Part 1: make @Resource work for Validator and ValidatorFactory

Part 2: Make java:comp/Validator and java:comp/ValidatorFactory work in JNDI

Author: Ken Saks and Ed Burns

M deployment/dol/src/main/java/com/sun/enterprise/deployment/JmsDestinationReferenceDescriptor.java

- Make this class aware of Validator and ValidatorFactory as valid
  JmsDestinations.

M common/container-common/src/main/java/com/sun/enterprise/container/common/impl/ComponentEnvManagerImpl.java

- Factory boilerplate code for obtaining a reference to an instance of
  Validator or ValidatorFactory.

Ed

-- 
| ed.burns_at_sun.com  | office: 408 884 9519 OR x31640
| homepage:         | http://ridingthecrest.com/