dev@glassfish.java.net

Resend: [REVIEW REQUEST] (was: Re: Seeking review for top level pom changes (was: Re: status: building from clean once more))

From: Ed Burns <Ed.Burns_at_Sun.COM>
Date: Wed, 21 Oct 2009 08:58:30 -0700

>>>>> On Tue, 20 Oct 2009 21:01:20 -0700, Ed Burns <ed.burns_at_sun.com> said:
>>>>> On Tue, 20 Oct 2009 17:57:01 -0700, Ed Burns <ed.burns_at_sun.com> said:
>>>>> On Tue, 20 Oct 2009 16:03:00 -0700, Jane Young <Jane.Young_at_Sun.COM> said:

JY> It's fine to promote.

EB> The promotion is currently running. This should give us 0.4.3.

EB> http://hudson.sfbay.sun.com/job/hk2/batchTasks/task/release/1167-1/

EB> The promotion appears to have succeeded.

EB> I have done a clean local build and ran the QL. They succeeded. I
EB> request permission to make the following change to the top level pom.xml

EB> Index: pom.xml
EB> ===================================================================
EB> --- pom.xml (revision 33038)
EB> +++ pom.xml (working copy)
EB> @@ -112,8 +112,8 @@
EB> <commons.collections.version>2.1</commons.collections.version>
EB> <commons.digester.version>1.5</commons.digester.version>
EB> <commons.modeler.version>1.1</commons.modeler.version>
EB> - <hk2.version>0.4.2</hk2.version>
EB> - <hk2.plugin.version>0.4.2</hk2.plugin.version>
EB> + <hk2.version>0.4.3</hk2.version>
EB> + <hk2.plugin.version>0.4.3</hk2.plugin.version>
EB> <jsr223-api.version>1.0</jsr223-api.version>
EB> <phobos.version>0.5.10</phobos.version>
EB> <product.name>GlassFish</product.name>

I'm still waiting for approval on this. For good measure, I've buit the
whole thing on Solaris as well as Mac OS X, and ran the QL and BV
integration test in both places and got the expected results. I can't
check in my fix for 10030 until this pom change goes in.

Please advise.

Ed

-- 
| ed.burns_at_sun.com  | office: 408 884 9519 OR x31640
| homepage:         | http://ridingthecrest.com/