dev@glassfish.java.net

FindBugs pom.xml changes

From: Bill Shannon <bill.shannon_at_sun.com>
Date: Thu, 01 Oct 2009 16:08:00 -0700

Jane seems to be on vacation so hopefully someone else can review these
changes...

These fix two bugs:

- The current FindBugs plugin version is 2.0.1; 2.1 was a publishing error.
- FindBugs wasn't properly handling the exclude files when run from the top
  level project.

Thanks.


Index: persistence/cmp/support-sqlstore/pom.xml
===================================================================
--- persistence/cmp/support-sqlstore/pom.xml (revision 31936)
+++ persistence/cmp/support-sqlstore/pom.xml (working copy)
@@ -62,7 +62,7 @@
     </developers>

     <properties>
- <findbugs.exclude>exclude.xml</findbugs.exclude>
+ <findbugs.exclude>${project.basedir}/exclude.xml</findbugs.exclude>
     </properties>

     <build>
Index: persistence/cmp/support-ejb/pom.xml
===================================================================
--- persistence/cmp/support-ejb/pom.xml (revision 31936)
+++ persistence/cmp/support-ejb/pom.xml (working copy)
@@ -62,7 +62,7 @@
     </developers>

     <properties>
- <findbugs.exclude>exclude.xml</findbugs.exclude>
+ <findbugs.exclude>${project.basedir}/exclude.xml</findbugs.exclude>
     </properties>

     <build>
Index: pom.xml
===================================================================
--- pom.xml (revision 31936)
+++ pom.xml (working copy)
@@ -681,7 +681,7 @@
            <plugin>
                <groupId>org.codehaus.mojo</groupId>
                <artifactId>findbugs-maven-plugin</artifactId>
- <version>2.1</version>
+ <version>2.0.1</version>
                <configuration>
                    <threshold>High</threshold>
                    <excludeFilterFile>${findbugs.exclude}</excludeFilterFile>
@@ -697,7 +697,7 @@
            <plugin>
                <groupId>org.codehaus.mojo</groupId>
                <artifactId>findbugs-maven-plugin</artifactId>
- <version>2.1</version>
+ <version>2.0.1</version>
                <configuration>
                    <threshold>High</threshold>
                    <excludeFilterFile>${findbugs.exclude}</excludeFilterFile>
Index: transaction/jts/pom.xml
===================================================================
--- transaction/jts/pom.xml (revision 31936)
+++ transaction/jts/pom.xml (working copy)
@@ -1,4 +1,41 @@
 <?xml version="1.0" encoding="UTF-8"?>
+<!--
+/*
+* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
+*
+* Copyright 1997-2009 Sun Microsystems, Inc. All rights reserved.
+*
+* The contents of this file are subject to the terms of either the GNU
+* General Public License Version 2 only ("GPL") or the Common Development
+* and Distribution License("CDDL") (collectively, the "License"). You
+* may not use this file except in compliance with the License. You can obtain
+* a copy of the License at https://glassfish.dev.java.net/public/CDDL+GPL.html
+* or glassfish/bootstrap/legal/LICENSE.txt. See the License for the specific
+* language governing permissions and limitations under the License.
+*
+* When distributing the software, include this License Header Notice in each
+* file and include the License file at glassfish/bootstrap/legal/LICENSE.txt.
+* Sun designates this particular file as subject to the "Classpath" exception
+* as provided by Sun in the GPL Version 2 section of the License file that
+* accompanied this code. If applicable, add the following below the License
+* Header, with the fields enclosed by brackets [] replaced by your own
+* identifying information: "Portions Copyrighted [year]
+* [name of copyright owner]"
+*
+* Contributor(s):
+*
+* If you wish your version of this file to be governed by only the CDDL or
+* only the GPL Version 2, indicate your decision by adding "[Contributor]
+* elects to include this software in this distribution under the [CDDL or GPL
+* Version 2] license." If you don't indicate a single choice of license, a
+* recipient has the option to distribute your version of this file under
+* either the CDDL, the GPL Version 2 or to extend the choice of license to
+* its licensees as provided above. However, if you add GPL Version 2 code
+* and therefore, elected the GPL Version 2 license, then the option applies
+* only if the new code is made subject to such option by the copyright
+* holder.
+*/
+-->
 <project xmlns="http://maven.apache.org/POM/4.0.0"
          xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
@@ -28,7 +65,7 @@
     </developers>

     <properties>
- <findbugs.exclude>exclude.xml</findbugs.exclude>
+ <findbugs.exclude>${project.basedir}/exclude.xml</findbugs.exclude>
     </properties>

     <build>
Index: common/common-util/pom.xml
===================================================================
--- common/common-util/pom.xml (revision 31936)
+++ common/common-util/pom.xml (working copy)
@@ -51,7 +51,7 @@
     <name>Common Utilities</name>

     <properties>
- <findbugs.exclude>exclude.xml</findbugs.exclude>
+ <findbugs.exclude>${project.basedir}/exclude.xml</findbugs.exclude>
     </properties>

     <developers>
Index: security/core/pom.xml
===================================================================
--- security/core/pom.xml (revision 31936)
+++ security/core/pom.xml (working copy)
@@ -60,7 +60,7 @@
     </developers>

     <properties>
- <findbugs.exclude>exclude.xml</findbugs.exclude>
+ <findbugs.exclude>${project.basedir}/exclude.xml</findbugs.exclude>
     </properties>

     <build>