dev@glassfish.java.net

Re: Review : Changes to security/core/pom.xml

From: Sahoo <Sahoo_at_Sun.COM>
Date: Wed, 23 Sep 2009 16:25:03 +0530

Nithya,

Two comments:
1. Why are you copying the dependency in "clean" phase?
2. Why are you copying it to src/main/resources?

Can't you copy them to target/classes directory in post-compile phase?

Thanks,
Sahoo

Nithya Subramanian wrote:
> These changes are meant to download the libsolarisauth.so files from
> maven repository to be copied into security/core/resources during the
> clean phase, to be later copied into the jar file during the build phase.
> This change would eliminate the need to have the .so files in the
> source code. Please approve..
>
> Thanks,
> Nithya
>
> Index: pom.xml
> ===================================================================
> --- pom.xml (revision 31738)
> +++ pom.xml (working copy)
> @@ -139,6 +139,39 @@
> </archive>
> </configuration>
> </plugin>
> +<plugin>
> + <groupId>org.apache.maven.plugins</groupId>
> + <artifactId>maven-dependency-plugin</artifactId>
> + <executions>
> + <execution>
> + <id>copy-installed</id>
> + <phase>clean</phase>
> + <goals>
> + <goal>copy</goal>
> + </goals>
> + <configuration>
> + <artifactItems>
> + <artifactItem>
> + <groupId>solarisrealm</groupId>
> + <artifactId>libsolsparcauth</artifactId>
> + <version>1.0</version>
> + <type>so</type>
> + </artifactItem>
> + <artifactItem>
> + <groupId>solarisrealm</groupId>
> + <artifactId>libsolx86auth</artifactId>
> + <version>1.0</version>
> + <type>so</type>
> + </artifactItem>
> + </artifactItems>
> + <stripVersion>
> + true
> + </stripVersion>
> + <outputDirectory>src/main/resources/lib</outputDirectory>
> + </configuration>
> + </execution>
> + </executions>
> + </plugin>
> </plugins>
> </build>
> <dependencies>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>