dev@glassfish.java.net

Re: please approve change to amx-ext-impl/pom.xml (connectors-runtime)

From: Jerome Dochez <Jerome.Dochez_at_Sun.COM>
Date: Tue, 22 Sep 2009 17:36:22 -0700

I don't think this import is right. Outside if obvious modularity
concerns, this would make connector runtime mandatory is less
sophisticated distributions. Looks like we should have interfaces in
internal-api, impl in connector rutime and AMX should look up the impl
in the habitat(with a potential null return). Make sense ?

Jerome

On Sep 22, 2009, at 16:02, Lloyd Chambers <Lloyd.Chambers_at_Sun.COM>
wrote:

> I don't have an answer to that question, and I also do not like the
> dependency.
>
> The goal is to provide a method for the GUI to call to force the JMS
> broker to load:
> https://glassfish.dev.java.net/issues/show_bug.cgi?id=8990
>
> This is what has to be imported:
>
> import com.sun.enterprise.connectors.ConnectorRuntime;
> import com.sun.appserv.connectors.internal.api.ConnectorConstants;
> import com.sun.appserv.connectors.internal.api.ConnectorsUtil;
> import com.sun.enterprise.connectors.ConnectorRegistry;
>
>
>
> On Sep 22, 2009, at 3:56 PM, Snjezana Sevo-Zenzerovic wrote:
>
>> Note that the unwanted side-effect of this change will be that
>> connectors-runtime.jar will magically move from glassfish-jca
>> package (where it is supposed to be) into glassfish-common package
>> (where AMX jars are)...
>>
>> There is connectors-internal-api jar already in glassfish-common
>> package. Is there any way to reshuffle things and have the
>> dependency on that jar?
>>
>> Thanks,
>>
>> Snjezana
>>
>>
>> Lloyd Chambers wrote:
>>> This change is to support a new method loadJMSBroker(), per
>>> request of the GUI team.
>>>
>>>
>>> llcMule-2:amx-ext-impl llc$ svn diff pom.xml
>>> Index: pom.xml
>>> ===================================================================
>>> --- pom.xml (revision 31713)
>>> +++ pom.xml (working copy)
>>> @@ -106,5 +106,11 @@
>>> <version>3.0.0-b004</version>
>>> </dependency>
>>>
>>> + <dependency>
>>> + <groupId>org.glassfish.connectors</groupId>
>>> + <artifactId>connectors-runtime</artifactId>
>>> + <version>${project.version}</version>
>>> + </dependency>
>>> +
>>> </dependencies>
>>> </project>
>>>
>>>
>>> ---
>>> ------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
> Lloyd Chambers
> lloyd.chambers_at_sun.com
> GlassFish Team
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>