dev@glassfish.java.net

Please remember to wrap logger.finest calls

From: Jan Luehe <Jan.Luehe_at_Sun.COM>
Date: Fri, 11 Sep 2009 11:32:50 -0700

I am seeing several places in the GlassFish v3 code where logging at
FINEST level
is not wrapped inside "if (logger.isLoggable(Level.FINEST))".

For example (in monitoring):

    logger.finest(
        "[TM]requestStartEvent Unprocessed received - virtual-server = " +
        request.getServerName() + ":" + request.getServerPort() +
        ": application = " + request.getContextPath() +
        " : servlet = " + request.getServletPath() +
        " : Expecting (vsName, appName) = (" +
        virtualServerName + ", " + moduleName + ")");

This will cause the logging message to be assembled even at the
default INFO level, where it won't be logged!

Please remember to wrap, as follows:

  if (logger.isLoggable(Level.FINEST)) {
      logger.finest(...);
  }

Thanks!

Jan