dev@glassfish.java.net

Re: code review needed - new local authentication mechanism

From: Lloyd Chambers <Lloyd.Chambers_at_Sun.COM>
Date: Mon, 17 Aug 2009 21:39:32 -0700

You're right. I assume the permissions are not affected there...

On Aug 17, 2009, at 4:54 PM, Bill Shannon wrote:

> Bill Shannon wrote on 08/17/09 16:43:
>> Lloyd Chambers wrote on 08/17/09 16:14:
>> > 3. Just a weird minor flaw not peculiar to your code:
>> postConstruct() can be called by anything at any time, since it's
>> public. So even a mistake is a problem and could defeat the local
>> password until the servew is restarted: the code as written
>> overwrites the in-memory password, which would then differ from the
>> one on disk. Probably this should be more defensive.
>
> Actually, it will rewrite the one on disk too, so this should be safe.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>

Lloyd Chambers
lloyd.chambers_at_sun.com
GlassFish Team