Sahoo wrote:
> Snjezana Sevo-Zenzerovic wrote:
>> Removing the domain directory from the staging area will work, but
>> this also means that build will need to recreate the domain each time
>> distributions module is built and that's something we originally
>> wanted to avoid for incremental builds. So, other option would be to
>> look for the presence of the default domain directory and skip the
>> domain creation step in that scenario.
>
> This optimisation can cause problems. Imagine a user updates the
> workspace and now create-domain produces different set of files (let's
> say a different domain.xml). Because of the above optimization, we won't
> run create-domain and hence would end up using old files.
Although I think that this applies only to developers who work on config files
and what goes into the domain folder (e.g. this is all right if you are
working on core/kernel) but I agree with the essence of what you say.
Any build the distributions and packager module should result in fresh
deletion (if exists) of default domain and recreation.
Same is true with scripts and other things (e.g. asadmin script should be
rebundled from wherever it resides in the codebase).
-Kedar
>
> Sahoo
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>