On 07/ 2/09 10:39 AM, Jan Luehe wrote:
> On 07/ 1/09 10:07 PM, Sahoo wrote:
>> Jan,
>>
>> I don't understand why you have to move javax.servlet from web to
>> javaee-api dir. Maven should auyomatically take care of build order.
>> Are you noticing any circular dependency problem? If so, can you
>> please send the build output?
>
> False alarm, this is working as you had predicted.
>
> Can you or Jane please review the required pom.xml change:
>
> Index: common/common-util/pom.xml
> ===================================================================
> --- common/common-util/pom.xml (revision 28406)
> +++ common/common-util/pom.xml (working copy)
> @@ -124,5 +124,10 @@
> <groupId>org.glassfish.common</groupId>
> <artifactId>glassfish-api</artifactId>
> </dependency>
> + <dependency>
> + <groupId>org.glassfish</groupId>
> + <artifactId>javax.servlet</artifactId>
> + <version>3.0-SNAPSHOT</version>
I've changed "3.0-SNAPSHOT" to "${project.version}", based
on Jane's review comment (should have known this).
Jan
> + </dependency>
> </dependencies>
> </project>
>
>
> Thanks,
>
> Jan
>
>>
>> Thanks,
>> Sahoo
>>
>> Jan Luehe wrote:
>>>
>>> ProxyHandler.java imports javax.servlet.http.HttpServletRequest, so
>>> if we
>>> moved it to "common/common-util", then we would also have to move
>>> "web/javax.servlet" to "javaee-api/javax.servlet", since "common"
>>> builds after
>>> "javaee-api", and to avoid any circular dependencies between
>>> "common" and "web".
>>>
>>> Does anybody see any issues with moving "web/javax.servlet" to
>>> "javaee-api/javax.servlet"?
>>>
>>> Thanks,
>>>
>>> Jan
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>