dev@glassfish.java.net

Re: Please review POM changes

From: Jane Young <Jane.Young_at_Sun.COM>
Date: Mon, 15 Jun 2009 16:50:04 -0700

I don't think it overrides, the version from dependencyManagement is
inherited to the child POMs.

Jennifer Chou wrote:
> From my understanding, when you add gmbal also under
> dependencyManagement of the root level pom, that version specified
> will override the version ones in admin/monitor and web/admin.
> Can somebody confirm?
>
> Lloyd Chambers wrote:
>> What I meant was:
>>
>> Does the root level version for gmbal override the version-less ones
>> in admin/monitor and web/admin?
>>
>> Lloyd
>>
>> On Jun 15, 2009, at 4:15 PM, Lloyd Chambers wrote:
>>
>>> Should there be a version included for gmbal?
>>>
>>> On Jun 15, 2009, at 4:12 PM, Jennifer Chou wrote:
>>>
>>>> Also adding the gmbal dependency to web/admin and admin/monitor
>>>> pom.xml and updated the dependencyManagement.
>>>> Jane - can you review also these changes? thanks, Jennifer
>>>>
>>>> *v3 pom.xml:*
>>>> Index: pom.xml
>>>> ===================================================================
>>>> --- pom.xml (revision 27881)
>>>> +++ pom.xml (working copy)
>>>> @@ -157,7 +157,8 @@
>>>> <jersey.version>1.1.0-ea</jersey.version>
>>>> <jbi.version>1.0</jbi.version>
>>>> <wsdl4j.version>1.6.2</wsdl4j.version>
>>>> -
>>>> <gfprobe-provider-client.version>3.0.0-b001</gfprobe-provider-client.version>
>>>> +
>>>> <gfprobe-provider-client.version>3.0.0-b004</gfprobe-provider-client.version>
>>>> + <gmbal.version>3.0.0-b004</gmbal.version>
>>>> </properties>
>>>>
>>>>
>>>> @@ -843,6 +844,11 @@
>>>> <version>${wsdl4j.version}</version>
>>>> </dependency>
>>>> <dependency>
>>>> + <groupId>org.glassfish.gmbal</groupId>
>>>> + <artifactId>gmbal</artifactId>
>>>> + <version>${gmbal.version}</version>
>>>> + </dependency>
>>>> + <dependency>
>>>> <groupId>org.glassfish.provider</groupId>
>>>> <artifactId>gfprobe-provider-client</artifactId>
>>>> <version>${gfprobe-provider-client.version}</version>
>>>>
>>>> *admin/monitor pom.xml:*
>>>> Index: pom.xml
>>>> ===================================================================
>>>> --- pom.xml (revision 27881)
>>>> +++ pom.xml (working copy)
>>>> @@ -113,6 +113,14 @@
>>>> <artifactId>flashlight-framework</artifactId>
>>>> <version>${project.version}</version>
>>>> </dependency>
>>>> + <dependency>
>>>> + <groupId>org.glassfish.provider</groupId>
>>>> + <artifactId>gfprobe-provider-client</artifactId>
>>>> + </dependency>
>>>> + <dependency>
>>>> + <groupId>org.glassfish.gmbal</groupId>
>>>> + <artifactId>gmbal</artifactId>
>>>> + </dependency>
>>>> </dependencies>
>>>> <reporting>
>>>> <plugins>
>>>>
>>>> *web/admin pom.xml:*
>>>> Index: pom.xml
>>>> ===================================================================
>>>> --- pom.xml (revision 27882)
>>>> +++ pom.xml (working copy)
>>>> @@ -88,7 +88,7 @@
>>>> <artifactId>monitoring-core</artifactId>
>>>> <version>${project.version}</version>
>>>> </dependency>
>>>> - <dependency>
>>>> + <dependency>
>>>> <groupId>com.sun.enterprise</groupId>
>>>> <artifactId>hk2</artifactId>
>>>> </dependency>
>>>> @@ -133,8 +133,11 @@
>>>> <dependency>
>>>> <groupId>org.glassfish.provider</groupId>
>>>> <artifactId>gfprobe-provider-client</artifactId>
>>>> - <version>${gfprobe-provider-client.version}</version>
>>>> </dependency>
>>>> + <dependency>
>>>> + <groupId>org.glassfish.gmbal</groupId>
>>>> + <artifactId>gmbal</artifactId>
>>>> + </dependency>
>>>> </dependencies>
>>>> </project>
>>>>
>>>>
>>>>
>>>>
>>>> Jane Young wrote:
>>>>> Please add the dependencies of gfprobe-provider-client and gmbal
>>>>> artifacts to dependencyManagement in v3/pom.xml.
>>>>>
>>>>>
>>>>> Jennifer Chou wrote:
>>>>>> Hi pom reviewers,
>>>>>>
>>>>>> Can you please review the following changes to v3/pom.xml and
>>>>>> admin/monitoring/pom.xml for monitoring?
>>>>>>
>>>>>> Thanks,
>>>>>> Jennifer
>>>>>>
>>>>>> ------------------------------------------------------------------------
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>
>>>>
>>>
>>> Lloyd Chambers
>>> lloyd.chambers_at_sun.com <mailto:lloyd.chambers_at_sun.com>
>>> GlassFish Team
>>>
>>>
>>>
>>
>> Lloyd Chambers
>> lloyd.chambers_at_sun.com <mailto:lloyd.chambers_at_sun.com>
>> GlassFish Team
>>
>>
>>
>