dev@glassfish.java.net

Re: Please review pom.xml (common/glassfish-api)

From: Snjezana Sevo-Zenzerovic <Snjezana.Sevo-Zenzerovic_at_Sun.COM>
Date: Thu, 25 Jun 2009 11:29:00 -0700

Well, it turns out that I am seeing things again :-)

It was glassfish-common package that already contained gmbal.jar, not
glassfish-nucleus. So, yes, glassfish-api should use gmbal-api-only, if
possible.

Thanks,

Snjezana


Snjezana Sevo-Zenzerovic wrote:

> FWIW, this is currently somewhat moot point because something else
> already pulls in full gmbal.jar into glassfish-nucleus package. If we
> want to keep footprint for nucleus minimal, any component which is
> part of nucleus has to switch to gmbal-api-only...
>
> I'll run through glassfish-nucleus dependency tree in a moment and
> send the list of nucleus modules depending on gmbal...
>
> Thanks,
>
> Snjezana
>
> Jennifer Chou wrote:
>
>> Sahoo - Thanks for the review. Yes that's a good idea. I think I
>> should be able to use the api-only bundle for this. It seems to be
>> working for me.
>> If other modules already have a dependency on glassfish-api and they
>> also want to use gmbal-api-only, they would not need to add another
>> dependency for gmbal-api-only, right?
>>
>> C:\gfv3_1005\v3\common\glassfish-api>svn diff pom.xml
>> Index: pom.xml
>> ===================================================================
>> --- pom.xml (revision 28162)
>> +++ pom.xml (working copy)
>> @@ -71,6 +71,11 @@
>> <scope>provided</scope>
>> </dependency>
>> <dependency>
>> + <groupId>org.glassfish.gmbal</groupId>
>> + <artifactId>gmbal-api-only</artifactId>
>> + <version>${gmbal.version}</version>
>> + </dependency>
>> + <dependency>
>> <groupId>junit</groupId>
>> <artifactId>junit</artifactId>
>> <version>4.3.1</version>
>>
>> fyi - Description of gmbal bundles from Ken:
>>
>> * gmbal (around 250KB): contains the API and full implementation
>> (this is what you will want to use)
>> * gmbal-api-only (around 14KB): contains the API and a very small
>> stub implementation. This is provided so core modules like
>> Grizzly can use gmbal and be packaged with optional MBean
>> support to allow for the smallest possible distribution.
>> * gmbal-source: contains all of the source code
>>
>> Jennifer
>>
>> Sahoo wrote:
>>
>>> I thought gmbal is divided into a separate API and impl bundle. If
>>> that's the case, can you just depend on api bundle?
>>>
>>> Sahoo
>>>
>>> Jennifer Chou wrote:
>>>
>>>> Please review common/glassfish-api pom.xml. I added gmbal to
>>>> dependency in common/glassfish-api pom.xml so I can annotate the
>>>> CountStatistic, TimeStatistic, etc with @ManagedData and
>>>> @ManagedAttribute. This will allow the xxxStatistic attributes of
>>>> a monitoring mbean to be displayed properly.
>>>>
>>>> Thanks,
>>>> Jennifer
>>>> ------------------------------------------------------------------------
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>
>