Looks fine.
You may want to consider adding the dependency to v3/pom.xml
dependencyManagement.
Jason Lee wrote:
> The following change to admingui/pom.xml updates the DynaFaces
> dependency to a version with a repeatable build, per the
> build-from-source-requirement:
>
> Index: pom.xml
> ===================================================================
> --- pom.xml (revision 27544)
> +++ pom.xml (working copy)
> @@ -130,9 +130,20 @@
> <scope>provided</scope>
> </dependency>
> <dependency>
> - <groupId>com.sun.jsftemplating</groupId>
> - <artifactId>jsftemplating-dynafaces</artifactId>
> - <version>0.1</version>
> + <groupId>com.sun.faces.extensions</groupId>
> + <artifactId>jsf-extensions-dynamic-faces</artifactId>
> + <version>0.2</version>
> + <classifier>jsftemplating</classifier>
> + <exclusions>
> + <exclusion>
> + <groupId>commons-logging</groupId>
> + <artifactId>commons-logging</artifactId>
> + </exclusion>
> + <exclusion>
> + <groupId>javax.faces</groupId>
> + <artifactId>shale-remoting</artifactId>
> + </exclusion>
> + </exclusions>
> </dependency>
> <dependency>
> <groupId>com.sun.faces</groupId>
>
>
> <http://www.java.com> * Jason Lee *
> Senior Java Developer
> GlassFish Administration Console
>
> *Sun Microsystems, Inc.*
> Phone x31197/+1 405-343-1964
> Email jasondlee_at_sun.com <mailto:jasondlee_at_sun.com>
> Blog http://blogs.sun.com/jasondlee
> Blog http://blogs.steeplesoft.com
>
>