I reverted Byron's changes locally on my workspace and ran QL tests
successfully.
But I just saw Byron's check-ins, svn rev 27184 at 6:46pm.
https://glassfish-svn.dev.java.net/source/browse/glassfish-svn/trunk/v3/admin/cli-framework/src/main/java/com/sun/enterprise/cli/framework/CLIMain.java?view=diff&rev=27184&p1=trunk/v3/admin/cli-framework/src/main/java/com/sun/enterprise/cli/framework/CLIMain.java&p2=trunk/v3/admin/cli-framework/src/main/java/com/sun/enterprise/cli/framework/CLIMain.java&r1=27183&r2=27184
Not sure if I should proceed in reverting back his changes.
Byron, please respond and let us know if you have fixed devtest issues.
Jane
Jane Young wrote:
> Okay, I'll revert Byron's changes. Give me 30min since I need to
> compile and run QL tests.
>
> Jane
>
>
> Amy Roh wrote:
>> Can we fix this today? We only had one successful devtest run today
>> immediately after reverting the commit and have been failing before
>> and after. It should be fixed immediately so that the tests can
>> catch further regressions in other areas.
>>
>> Thanks,
>> Amy
>>
>> Jane Young wrote:
>>> Byron,
>>>
>>> Please fix this. I'll revert your changes again since devtests are
>>> failing.
>>>
>>> Thanks,
>>> Jane
>>>
>>>
>>> Amy Roh wrote:
>>>> The problem seems to be back. The web devtests fail to start with
>>>> this message. Please fix this as web devtests have been failing
>>>> after once passing briefly following Jane's revert.
>>>>
>>>> [#|2009-05-07T15:02:44.485-0700|INFO|glassfish|null|_ThreadID=18;_ThreadName=Thread-1;|Command
>>>> start-domain not found|#]
>>>>
>>>> [#|2009-05-07T15:02:44.486-0700|SEVERE|glassfish|javax.enterprise.system.tools.admin.org.glassfish.server|_ThreadID=18;_ThreadName=Thread-1;|Command
>>>> start-domain not found|#]
>>>>
>>>> Jane Young wrote:
>>>>> I reverted your changes and looks like you committed your fix
>>>>> right after.
>>>>> Did you run QL to verify your changes?
>>>>>
>>>>>
>>>>> Byron Nevins wrote:
>>>>>> It is fixed now...
>>>>>>
>>>>>>
>>>>>> Jane Young wrote:
>>>>>>
>>>>>>> This behavior is also showing up in QL tests.
>>>>>>> See:
>>>>>>> http://gf-hudson.sfbay.sun.com/hudson/job/gf-trunk-build-continuous/1013/console
>>>>>>>
>>>>>>>
>>>>>>> I think it's related to Byron's commit, svn r27134.
>>>>>>>
>>>>>>> https://glassfish-svn.dev.java.net/source/browse/glassfish-svn/trunk/v3/admin/cli/src/main/java/com/sun/enterprise/admin/cli/AsadminMain.java?view=diff&rev=27134&p1=trunk/v3/admin/cli/src/main/java/com/sun/enterprise/admin/cli/AsadminMain.java&p2=trunk/v3/admin/cli/src/main/java/com/sun/enterprise/admin/cli/AsadminMain.java&r1=27133&r2=27134
>>>>>>>
>>>>>>>
>>>>>>> Byron, please fix this ASAP. QL tests are failing with your
>>>>>>> changes.
>>>>>>>
>>>>>>> Jane
>>>>>>>
>>>>>>>
>>>>>>> Hong Zhang wrote:
>>>>>>>
>>>>>>>> I updated my workspace this morning and I am seeing some really
>>>>>>>> weird behavior now (when I updated my workspace yesterday
>>>>>>>> morning, things were fine).
>>>>>>>>
>>>>>>>> 1. After I installed server, I started domain which is ok:
>>>>>>>>
>>>>>>>> hzhang_at_nmr:~/files/sun/glassfishv3/glassfish/bin$ ./asadmin
>>>>>>>> start-domain
>>>>>>>> Name of the domain started: [domain1] and
>>>>>>>> its location:
>>>>>>>> [/home/hzhang/files/sun/glassfishv3/glassfish/domains/domain1].
>>>>>>>> Admin port for the domain: [4848].
>>>>>>>>
>>>>>>>> 2. Then I tried to deploy a simple application, after it
>>>>>>>> complained the deploy is invalid command, it seems to try to
>>>>>>>> deploy the same application twice and telling me the --force
>>>>>>>> option should be used.
>>>>>>>>
>>>>>>>> hzhang_at_nmr:~/files/sun/glassfishv3/glassfish/bin$ ./asadmin
>>>>>>>> deploy ~/deployment/apps/hello1.war
>>>>>>>> CLI001 Invalid Command, deploy.
>>>>>>>> remote failure: Error during deployment : Application hello1
>>>>>>>> already registered, please use deploy --force=true to
>>>>>>>> redeploy : java.lang.Exception: Application h ello1
>>>>>>>> already registered, please use deploy --force=true to redeploy
>>>>>>>> Command deploy failed.
>>>>>>>>
>>>>>>>> 3. Now I tried to list components, it again complained the
>>>>>>>> command is invalid command and then list the application twice.
>>>>>>>>
>>>>>>>> hzhang_at_nmr:~/files/sun/glassfishv3/glassfish/bin$ ./asadmin
>>>>>>>> list-components
>>>>>>>> CLI001 Invalid Command, list-components.
>>>>>>>> hello1 <web>
>>>>>>>> hello1 <web>
>>>>>>>> Command list-components executed successfully.
>>>>>>>>
>>>>>>>> The application was still usable afterwards (I could access the
>>>>>>>> app at localhost:8080/hello1) which explained why most the QL
>>>>>>>> tests are still passing in hudson..
>>>>>>>>
>>>>>>>> - Hong
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>