Hong Zhang wrote:
> Ludo/Vince
> I have talked with Jerome, seems the best option now is to expose
> both parameters (property and properties) so we keep backward
> compatibility with both v3.prelude and v2.. I have just checked in the
> changes for it. Please let me know if you still see problem. Thanks.
>
You mean --properties is synonymous with --property? I now --property supports
definition of multiple properties delimited by ':'. Does --properties do the
same?
IMO, if the damage is small, we should support only one of them.
-Kedar
> - Hong
>
>>>
>>>>>>>>> I see this from NB which is using
>>>>>>>>> http://localhost:4848/__asadmin/deploy?path=/Users/ludo/acvs/ndc/WebApplication3/build/web&name=WebApplication3&force=true&properties=keepSessions=true
>>>>>>>>>
>>>>>>>>>
>>>>>>>> You should use "property" instead of "properties":
>>>>>>>> http://localhost:4848/__asadmin/deploy?path=/Users/ludo/acvs/ndc/WebApplication3/build/web&name=WebApplication3&force=true&property=keepSessions=true
>>>>>>>>
>>>>>>>>
>>>>>>>> Was the "properties" working before? As far as I know, it was
>>>>>>>> "property" instead of "properties" since v2?
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Weird... property works, but we have been using properties in
>>>>>>> Eclipse and NetBeans up to now...
>>>>>>> We can change but can we track the change that triggered this?
>>>>>>
>>>>>>
>>>>>>
>>>>> Ok, I found the check in (I don't even remember me making this
>>>>> change!):
>>>>> https://glassfish-svn.dev.java.net/source/browse/glassfish-svn?rev=24192&view=rev
>>>>>
>>>>>
>>>>> From the commit message, it seems I did it to add support for
>>>>> "property" option to maintain backward compatibility with v2. I did
>>>>> not realize that people were actually using the "properties" (which
>>>>> I believe intended to be property). As the property (or properties)
>>>>> option was not officially documented in v3.prelude as one of the
>>>>> officially supported options (not in the prelude deployment
>>>>> one-pager or deploy command man page), there should not be a big
>>>>> issue of v3 prelude backward compability here? ;-)
>>>>>
>>>> Well, it just breaks all NetBeans and Eclipse users how try to use
>>>> the latest v3 bits...
>>>> So what do we do?
>>>
>>>
>>> (This is the risk of using an un-officially supported option ;-) )
>>
>> Looks like it was pretty official to some of the other folks on the
>> team...
>>
>> http://forums.java.net/jive/thread.jspa?messageID=302681
>> http://blogs.sun.com/quinn/entry/deployment_in_glassfish_v3_prelude
>> http://blogs.sun.com/jluehe/entry/retain_session_data_during_redeployment
>>
>>>
>>> How much change would it need for the NB/Eclipse plugins to switch
>>> from "properties" to "property"? If the change is really extensive,
>>> guess we will have to look into supporting both options in v3 deploy
>>> command? Other suggestions?
>>
>>
>> The change in the plugin is going to end up being pretty extensive,
>> since we have to support v3 Prelude and v3...
>> vbk
>>
>>>
>>> - Hong
>>>
>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>