From: Jane Young <Jane.Young_at_Sun.COM>
Date: Mon, 27 Apr 2009 11:45:36 -0700

Looks fine.


Hong Zhang wrote:
> Hi,
> This is to remove the dol dependency from ConnectorArchiveHandler (I
> was working on the other requirement from connector team and wanted to
> take care of this also). The ConnectorHandler currently uses the DOL
> classes to scan for annotations. I have refactored the more generic
> SnifferAnnotationScanner (using asm) in core/kernel and move the logic
> to a base class AnnotationScanner (located in the deployment/common)
> so both ArchiveHandler and Sniffer classes could take advantage of it.
> As a result, I have modified three pom.xml files.
> 1. The connector pom.xml have dol dependency removed.
> 2. The core/kernel has asm dependency removed as the code to use asm
> is moved to deployment-common module.
> 3. The deployment/common has asm dependnecy added as it now has the
> common class to scan annotations.
>
> Index: connectors/connectors-connector/pom.xml
> ===================================================================
> --- connectors/connectors-connector/pom.xml (revision 26639)
> +++ connectors/connectors-connector/pom.xml (working copy)
> @@ -43,12 +43,6 @@
> </dependency>
>
> <dependency>
> - <groupId>org.glassfish.deployment</groupId>
> - <artifactId>dol</artifactId>
> - <version>${project.parent.version}</version>
> - </dependency>
> -
> - <dependency>
> <groupId>org.glassfish.common</groupId>
> <artifactId>common-util</artifactId>
>
>
> Index: core/kernel/pom.xml
> ===================================================================
> --- pom.xml (revision 26639)
> +++ pom.xml (working copy)
> @@ -136,11 +136,6 @@
> <version>${project.version}</version>
> <scope>test</scope>
> </dependency>
> - <dependency>
> - <groupId>org.glassfish.external</groupId>
> - <artifactId>asm-all-repackaged</artifactId>
> - <version>${project.version}</version>
> - </dependency>
> <dependency>
> <groupId>com.sun.pkg</groupId>
> <artifactId>pkg-client</artifactId>
>
> Index: deployment/common/pom.xml
> ===================================================================
> --- deployment/common/pom.xml (revision 26639)
> +++ deployment/common/pom.xml (working copy)
> @@ -100,5 +100,10 @@
> <artifactId>common-util</artifactId>
> <version>${project.version}</version>
> </dependency>
> + <dependency>
> + <groupId>org.glassfish.external</groupId>
> + <artifactId>asm-all-repackaged</artifactId>
> + <version>${project.version}</version>
> + </dependency>
> </dependencies>
> </project>
>
>
> Thanks,
>
> - Hong
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>