dev@glassfish.java.net

Re: Review for changes to EJB-Connector pom.xml file

From: Sreenivas Munnangi <Sreenivas.Munnangi_at_Sun.COM>
Date: Wed, 22 Apr 2009 10:01:12 -0700

Marina Vatkina wrote:
> Aren't we keeping tests under v2/appserv-tests to separate them from
> the src?
These unit tests are in addition to v2/appserv-tests which are run as
part of the maven build.
>
> thanks,
> -marina
>
> Nachiappan Veerappan Nachiappan wrote:
>> Yes that is correct.
>>
>> Jane Young wrote:
>>
>>> The scope is test so I assume that this is related to command
>>> unit-tests.
>>>
>>>
>>> Marina Vatkina wrote:
>>>
>>>> Jane, Nachiappan,
>>>>
>>>> Why would ejb-connector now depend on org.glassfish.tests?
>>>>
>>>> thanks,
>>>> -marina
>>>>
>>>> Jane Young wrote:
>>>>
>>>>> Sorry for the confusion. Now I understand. Nachiappan is adding
>>>>> new command classes in ejb-connector module. Marina is reviewing
>>>>> the command java code. The dependencies are added in the pom.xml
>>>>> since the command java classes depend on it.
>>>>> Resources are added for the manpages.
>>>>>
>>>>> I'm fine with this change.
>>>>>
>>>>> Thanks,
>>>>> Jane
>>>>>
>>>>>
>>>>> Nachiappan Veerappan Nachiappan wrote:
>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> This is change which i am planning to make to ejb-connector
>>>>>> pom.xml file. In the last email i didn't not add the resources
>>>>>> elements. Sorry about that.
>>>>>>
>>>>>> Thanks,
>>>>>> Nachiappan
>>>>>>
>>>>>> nachi:ejb-connector $ svn diff pom.xml
>>>>>> Index: pom.xml
>>>>>> ===================================================================
>>>>>> --- pom.xml (revision 26497)
>>>>>> +++ pom.xml (working copy)
>>>>>> @@ -58,7 +58,24 @@
>>>>>> <role>lead</role>
>>>>>> </roles>
>>>>>> </developer>
>>>>>> - </developers> + </developers>
>>>>>> + <build>
>>>>>> + <resources>
>>>>>> + <resource>
>>>>>> + <directory>src/main/java</directory>
>>>>>> + <includes>
>>>>>> + <include>**/*.properties</include>
>>>>>> + <include>**/*.xsd</include>
>>>>>> + </includes>
>>>>>> + </resource>
>>>>>> + <resource>
>>>>>> + <directory>src/main/resources</directory>
>>>>>> + <includes>
>>>>>> + <include>**/*.1</include>
>>>>>> + </includes>
>>>>>> + </resource>
>>>>>> + </resources>
>>>>>> + </build> <dependencies>
>>>>>> <dependency>
>>>>>> <groupId>org.glassfish</groupId>
>>>>>> @@ -79,5 +96,22 @@
>>>>>> <groupId>com.sun.enterprise</groupId>
>>>>>> <artifactId>hk2</artifactId>
>>>>>> </dependency>
>>>>>> + <dependency>
>>>>>> + <groupId>org.glassfish.core</groupId>
>>>>>> + <artifactId>kernel</artifactId>
>>>>>> + <version>${project.version}</version>
>>>>>> + <scope>test</scope>
>>>>>> + </dependency>
>>>>>> + <dependency>
>>>>>> + <groupId>org.glassfish.tests</groupId>
>>>>>> + <artifactId>utils</artifactId>
>>>>>> + <version>${project.version}</version>
>>>>>> + <scope>test</scope>
>>>>>> + </dependency>
>>>>>> + <dependency>
>>>>>> + <groupId>org.glassfish.ejb</groupId>
>>>>>> + <artifactId>ejb-internal-api</artifactId>
>>>>>> + <version>${project.version}</version>
>>>>>> + </dependency>
>>>>>> </dependencies>
>>>>>> </project>
>>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>