dev@glassfish.java.net

pom.xml review -- add 'amx-core' dependency in GUI

From: Anissa Lam <Anissa.Lam_at_Sun.COM>
Date: Mon, 20 Apr 2009 17:28:16 -0700

I need to add one more dependency in the GUI modules that uses the new
amx-core API.
Please review the following changes:

Index: v3/admingui/common/pom.xml
===================================================================
--- v3/admingui/common/pom.xml (revision 26440)
+++ v3/admingui/common/pom.xml (working copy)
@@ -117,6 +117,12 @@
         <scope>provided</scope>
         </dependency>
         <dependency>
+ <groupId>org.glassfish.common</groupId>
+ <artifactId>amx-core</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
             <groupId>com.sun.jsftemplating</groupId>
             <artifactId>jsftemplating</artifactId>
             <version>${jsftemplating.version}</version>
Index: v3/admingui/core/pom.xml
===================================================================
--- v3/admingui/core/pom.xml (revision 26440)
+++ v3/admingui/core/pom.xml (working copy)
@@ -117,6 +117,12 @@
         <scope>provided</scope>
         </dependency>
         <dependency>
+ <groupId>org.glassfish.common</groupId>
+ <artifactId>amx-core</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
             <groupId>org.glassfish.security</groupId>
             <artifactId>securitycommon</artifactId>
             <version>${project.version}</version>
Index: v3/admingui/war/pom.xml
===================================================================
--- v3/admingui/war/pom.xml (revision 26440)
+++ v3/admingui/war/pom.xml (working copy)
@@ -58,7 +58,7 @@
          <archive>
           <manifestEntries>
           
<Glassfish-require-services>org.glassfish.api.admingui.ConsoleProvider</Glassfish-require-services>
-
<HK2-Import-Bundles>org.glassfish.admingui.console-common,com.sun.enterprise.hk2,org.glassfish.admingui.console-plugin-service,
org.glassfish.common.amx-api,
org.glassfish.deployment.deployment-client,org.glassfish.registration.registration-api,org.glassfish.registration.registration-impl,
org.glassfish.javax.servlet, org.glassfish.javax.servlet.jsp,
com.sun.jsftemplating, org.glassfish.admingui.dataprovider,
com.sun.pkg.client </HK2-Import-Bundles>
+
<HK2-Import-Bundles>org.glassfish.admingui.console-common,com.sun.enterprise.hk2,org.glassfish.admingui.console-plugin-service,
org.glassfish.common.amx-api,
org.glassfish.common.amx-core,org.glassfish.deployment.deployment-client,org.glassfish.registration.registration-api,org.glassfish.registration.registration-impl,
org.glassfish.javax.servlet, org.glassfish.javax.servlet.jsp,
com.sun.jsftemplating, org.glassfish.admingui.dataprovider,
com.sun.pkg.client </HK2-Import-Bundles>
           </manifestEntries>
          </archive>
             </configuration>
@@ -110,7 +110,7 @@
           <archive>
           <manifestEntries>
               
<Glassfish-require-services>org.glassfish.api.admingui.ConsoleProvider</Glassfish-require-services>
-
<HK2-Import-Bundles>org.glassfish.admingui.console-common,com.sun.enterprise.hk2,org.glassfish.admingui.console-plugin-service,
org.glassfish.common.amx-api,
org.glassfish.deployment.deployment-client,org.glassfish.registration.registration-api,org.glassfish.registration.registration-impl,
org.glassfish.javax.servlet, org.glassfish.javax.servlet.jsp,
com.sun.jsftemplating,
org.glassfish.admingui.dataprovider,com.sun.pkg.client</HK2-Import-Bundles>
+
<HK2-Import-Bundles>org.glassfish.admingui.console-common,com.sun.enterprise.hk2,org.glassfish.admingui.console-plugin-service,
org.glassfish.common.amx-api, org.glassfish.common.amx-core,
org.glassfish.deployment.deployment-client,org.glassfish.registration.registration-api,org.glassfish.registration.registration-impl,
org.glassfish.javax.servlet, org.glassfish.javax.servlet.jsp,
com.sun.jsftemplating,
org.glassfish.admingui.dataprovider,com.sun.pkg.client</HK2-Import-Bundles>
           </manifestEntries>
           </archive>
               <webResources>
Index: v3/admingui/web/pom.xml
===================================================================
--- v3/admingui/web/pom.xml (revision 26440)
+++ v3/admingui/web/pom.xml (working copy)
@@ -108,6 +108,12 @@
         <scope>provided</scope>
         </dependency>
         <dependency>
+ <groupId>org.glassfish.common</groupId>
+ <artifactId>amx-core</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
             <groupId>org.glassfish.deployment</groupId>
             <artifactId>deployment-client</artifactId>
             <version>${project.version}</version>


thanks
Anissa.