dev@glassfish.java.net

Re: Review Request for changes to ORB pom.xml files

From: Sreenivas Munnangi <Sreenivas.Munnangi_at_Sun.COM>
Date: Mon, 20 Apr 2009 15:37:04 -0700

Jerome Dochez wrote:
>
> On Apr 20, 2009, at 1:14 PM, Sreenivas Munnangi wrote:
>
>> Jerome Dochez wrote:
>>>
>>> the orb-connector is also a glassfish dependent glue module right ?
>> I see orb-connector module.
>>>
>>> if that is so, why having a separate admin module ?
>>> Are you planning that we may optionally ship one of these 2 modules ?
>>
>> Mostly it is for distribution of work rather than module. Also we
>> want to be consistent with other modules like jdbc/admin. We proposed
>> admin workspace structure earlier based on this. This allows us to
>> retain the ability to distribute admin module separately if needed.
> considering the runtime cost of having multiple modules, I don't think
> we can expect to implement the proposed structure you are pointing.
> as for jdbc-admin, if there is also a jdbc-connector, then its days
> are counted.
I see the point you are trying to make.
> I am not sure why distributing the admin part without the runtime is
> interesting, can you elaborate ?
The original idea was that admin module could be brought on demand and
will have a dependency on runtime, hence the provision for it. To reduce
number of modules, do you suggest that we can make an admin directory
under one of the orb modules and use it for delivering cli functionality ?
>
> jerome
>
>>
>>>
>>> jerome
>>>
>>> On Apr 20, 2009, at 11:51 AM, Sreenivas Munnangi wrote:
>>>
>>>> Sahoo wrote:
>>>>> The pom changes look OK to me. If the new module is going to be
>>>>> part of a distribution, then make changes in distribution and
>>>>> packager poms before checking in. For that, work with Jane and
>>>>> Snjezana resp. Pl. check with Jerome for the introduction of a new
>>>>> module.
>>>> This is consistent with other admin modules, for ex. jdbc/admin.
>>>> Nachi already checked with Ken and we'll verify with Jerome as
>>>> suggested by you.
>>>>>
>>>>> Sahoo
>>>>>
>>>>> Nachiappan Veerappan Nachiappan wrote:
>>>>>> Hello,
>>>>>>
>>>>>> I adding a new module under ORB directory called "admin" for the
>>>>>> ORB admin cli commands. I would request to review my pom.xml
>>>>>> changes.
>>>>>>
>>>>>> Thanks,
>>>>>> Nachiappan
>>>>>>
>>>>>> 1. v3/orb/pom.xml
>>>>>>
>>>>>> nachi:orb $ svn diff pom.xml
>>>>>> Index: pom.xml
>>>>>> ===================================================================
>>>>>> --- pom.xml (revision 26267)
>>>>>> +++ pom.xml (working copy)
>>>>>> @@ -51,5 +51,6 @@
>>>>>> <modules>
>>>>>> <module>orb-connector</module>
>>>>>> <module>orb-iiop</module>
>>>>>> + <module>admin</module>
>>>>>> </modules>
>>>>>> </project>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> 2. The new pom.xml for admin module under orb directory.
>>>>>> v3/orb/admin/pom.xml
>>>>>>
>>>>>> <project xmlns="http://maven.apache.org/POM/4.0.0"
>>>>>> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
>>>>>> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
>>>>>> http://maven.apache.org/maven-v4_0_0.xsd">
>>>>>>
>>>>>> <modelVersion>4.0.0</modelVersion>
>>>>>>
>>>>>> <parent>
>>>>>>
>>>>>> <groupId>org.glassfish.orb</groupId>
>>>>>>
>>>>>> <artifactId>orb</artifactId>
>>>>>>
>>>>>> <version>3.0-SNAPSHOT</version>
>>>>>>
>>>>>> </parent> <artifactId>orb-admin</artifactId>
>>>>>>
>>>>>> <packaging>hk2-jar</packaging>
>>>>>>
>>>>>> <name>ORB admin</name>
>>>>>>
>>>>>>
>>>>>>
>>>>>> <developers>
>>>>>>
>>>>>> <developer>
>>>>>>
>>>>>> <id>nachi_glassfish</id>
>>>>>>
>>>>>> <name>Nachiappan Veerappan Nachiappan</name>
>>>>>>
>>>>>> <url>http://blogs.sun.com/nachi</url>
>>>>>>
>>>>>> <organization>Sun Microsystems, Inc.</organization>
>>>>>>
>>>>>> <roles>
>>>>>>
>>>>>> <role>developer</role>
>>>>>>
>>>>>> </roles>
>>>>>>
>>>>>> </developer>
>>>>>>
>>>>>> </developers>
>>>>>>
>>>>>> <build>
>>>>>>
>>>>>> <resources>
>>>>>>
>>>>>> <resource>
>>>>>>
>>>>>> <directory>src/main/java</directory>
>>>>>>
>>>>>> <includes>
>>>>>>
>>>>>> <include>**/*.properties</include>
>>>>>>
>>>>>> <include>**/*.xsd</include>
>>>>>>
>>>>>> </includes>
>>>>>>
>>>>>> </resource>
>>>>>>
>>>>>> <resource>
>>>>>>
>>>>>> <directory>src/main/resources</directory>
>>>>>>
>>>>>> <includes>
>>>>>>
>>>>>> <include>**/*.1</include>
>>>>>>
>>>>>> </includes>
>>>>>>
>>>>>> </resource>
>>>>>>
>>>>>> </resources>
>>>>>>
>>>>>> </build>
>>>>>>
>>>>>> <dependencies>
>>>>>>
>>>>>> <dependency>
>>>>>>
>>>>>> <groupId>com.sun.enterprise</groupId>
>>>>>>
>>>>>> <artifactId>hk2</artifactId>
>>>>>>
>>>>>> </dependency>
>>>>>>
>>>>>> <dependency>
>>>>>>
>>>>>> <groupId>org.glassfish.admin</groupId>
>>>>>>
>>>>>> <artifactId>cli-framework</artifactId>
>>>>>>
>>>>>> <version>${project.version}</version>
>>>>>>
>>>>>> </dependency>
>>>>>>
>>>>>> <dependency>
>>>>>>
>>>>>> <groupId>org.glassfish.admin</groupId>
>>>>>>
>>>>>> <artifactId>config-api</artifactId>
>>>>>>
>>>>>> <version>${project.version}</version>
>>>>>>
>>>>>> </dependency>
>>>>>>
>>>>>> <dependency>
>>>>>>
>>>>>> <groupId>org.glassfish.common</groupId>
>>>>>>
>>>>>> <artifactId>glassfish-api</artifactId>
>>>>>>
>>>>>> </dependency>
>>>>>>
>>>>>> <dependency>
>>>>>>
>>>>>> <groupId>org.glassfish.core</groupId>
>>>>>>
>>>>>> <artifactId>kernel</artifactId>
>>>>>>
>>>>>> <version>${project.version}</version>
>>>>>>
>>>>>> <scope>test</scope>
>>>>>>
>>>>>> </dependency> <dependency>
>>>>>>
>>>>>> <groupId>org.glassfish.tests</groupId>
>>>>>>
>>>>>> <artifactId>utils</artifactId>
>>>>>>
>>>>>> <version>${project.version}</version>
>>>>>>
>>>>>> <scope>test</scope>
>>>>>>
>>>>>> </dependency>
>>>>>>
>>>>>> <dependency>
>>>>>>
>>>>>> <groupId>org.glassfish.admin</groupId>
>>>>>>
>>>>>> <artifactId>admin-cli</artifactId>
>>>>>>
>>>>>> <version>${project.version}</version>
>>>>>>
>>>>>> </dependency>
>>>>>>
>>>>>> </dependencies>
>>>>>>
>>>>>> </project>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>>>
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>