dev@glassfish.java.net

Re: Please review pom.xmls for Jdbc templates

From: Sahoo <Sahoo_at_Sun.COM>
Date: Wed, 15 Apr 2009 13:16:30 +0530

1. I don't think you need to declare maven-glassfishbuild-plugin as an
extension in that pom.xml. Pl. remove it.

2. I don't know the use of "resources" classifier. Do you know what's it
used for?

3. I am assuming you shall make another change to make this part of zip
and ips distribution.

Thanks,
Sahoo

Shalini Muthukrishnan wrote:
> Hi Sahoo,
>
> The JDBC templates would be a distribution fragment and will include
> all jdbc templates placed under src/main/resources.
> maven-antrun-extended-plugin is used to build the templates.jar and
> attach this artifact as a jar with classifier "resources".
>
> HTH,
> Shalini.
>
> Sahoo wrote:
>> Shalini,
>>
>> While I understand the change made in jdbc-ra-distribution/pom.xml
>> and jdbc/pom.xml, I am not sure I understand everything inside
>> templates/pom.xml. Can you explain what you have written?
>>
>> Thanks,
>> Sahoo
>>
>> Shalini Muthukrishnan wrote:
>>> Hi Jane/Sahoo/Jerome,
>>>
>>> Please review the pom.xml added for a new module "templates"
>>> (attached) under v3/jdbc along with the changes to the jdbc pom.xml
>>> and jdbc-ra-distribution pom.xml.
>>>
>>> This is to add support for installing jdbc connection pool/resource
>>> templates to the glassfish/lib/install/templates directory.
>>>
>>> Please provide your inputs by EOD today so i can commit the changes.
>>>
>>> Thanks,
>>> Shalini.
>>>
>>> Index: jdbc/pom.xml
>>> ===================================================================
>>> --- jdbc/pom.xml (revision 26104)
>>> +++ jdbc/pom.xml (working copy)
>>> @@ -69,5 +69,6 @@
>>> <modules>
>>> <module>jdbc-ra</module>
>>> <module>admin</module>
>>> + <module>templates</module>
>>> </modules>
>>> </project>
>>>
>>>
>>> Index: jdbc/jdbc-ra/jdbc-ra-distribution/pom.xml
>>> ===================================================================
>>> --- jdbc/jdbc-ra/jdbc-ra-distribution/pom.xml (revision 26104)
>>> +++ jdbc/jdbc-ra/jdbc-ra-distribution/pom.xml (working copy)
>>> @@ -25,10 +25,12 @@
>>> <resolveArtifact artifactId="jdbc-core"
>>> groupId="org.glassfish.jdbc.jdbc-ra.jdbc-core" property="core.jar"/>
>>> <resolveArtifact artifactId="jdbc30"
>>> groupId="org.glassfish.jdbc.jdbc-ra.jdbc30" property="30.jar"/>
>>> <resolveArtifact artifactId="jdbc40"
>>> groupId="org.glassfish.jdbc.jdbc-ra.jdbc40" property="40.jar"/>
>>> + <resolveArtifact artifactId="templates"
>>> groupId="org.glassfish.jdbc" property="templates.jar"/>
>>>
>>> <unjar src="${core.jar}" dest="target/classes"/>
>>> <unjar src="${30.jar}" dest="target/classes"/>
>>> <unjar src="${40.jar}" dest="target/classes"/>
>>> + <unjar src="${templates.jar}"
>>> dest="target/classes/templates"/>
>>>
>>> <!-- Creating jars/rars done using ant build.xml -->
>>> <property name="compile_classpath"
>>> refid="maven.compile.classpath"/>
>>> @@ -68,5 +70,12 @@
>>> <version>${project.parent.version}</version>
>>> </dependency>
>>>
>>> + <dependency>
>>> + <groupId>org.glassfish.jdbc</groupId>
>>> + <artifactId>templates</artifactId>
>>> + <version>${project.parent.version}</version>
>>> + <type>distribution-fragment</type>
>>> + </dependency>
>>> +
>>> </dependencies>
>>> </project>
>>>
>>> ------------------------------------------------------------------------
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
>> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_glassfish.dev.java.net
> For additional commands, e-mail: dev-help_at_glassfish.dev.java.net
>