dev@glassfish.java.net

Re: RESEND - BLOCKING - Re: [action] pom and glassfish distribution changes and additions

From: Jane Young <Jane.Young_at_Sun.COM>
Date: Tue, 14 Apr 2009 18:24:03 -0700

Not sure if you ever got a response from Jerome or Sahoo:

Here are some comments:

===================================================================
--- appclient/client/appclient-scripts/pom.xml (revision
26111)
+++ appclient/client/appclient-scripts/pom.xml (working
copy)
@@ -2,13 +2,21 @@
                                                                                                          

     
<modelVersion>4.0.0</modelVersion>

     
<parent>

-
<groupId>org.glassfish</groupId>

-
<artifactId>appclient</artifactId>

+
<groupId>org.glassfish.appclient</groupId>

+
<artifactId>client</artifactId>

         
<version>3.0-SNAPSHOT</version>

     
</parent>

-

+ <!-- we seem to need to explicitly specify the groupId for a dist
frag ??? -->
+
<groupId>org.glassfish.appclient.client</groupId>

     
<artifactId>appclient-scripts</artifactId>

     <name>GlassFish appclient scripts</name>

The reason why you need to explicitly specify the groupId is because it
is different than the parent's groupId. Is there a reason why this
artifact has a different groupId from the parent?

Parent groupId: org.glassfish.appclient
Child groupId: org.glassfish.appclient.client

Looks like the appclient-scripts module copies the files from
acc-standalone to a structured glassfish distribution directory and
then zipping-it so it's in the project's target directory and publishing
to maven repo. Distrubtion pulls this module and extracts appclient to
the glassfish bin location. The steps looks cumbersome.

This is temporary? What is the right solution? If you've worked this
out with Snjezana, the changes are fine with me.

Thanks,
Jane





Tim Quinn wrote:
> Hi.
>
> I sent this yesterday. Could someone please review and respond today
> (Tuesday U.S.)?
>
> Thanks.
>
> - Tim
>
> Tim Quinn wrote:
>> Hi.
>>
>> The attached zip file contains diffs and raw files for several
>> changes to poms and changes to the glassfish distribution.
>>
>> I have created a new appclient-all module which depends on all the
>> various appclient modules. As a favor to me Snjezana had hacked the
>> glassfish distribution pom and build.xml files to gather the
>> individual appclient-related modules. This new module does that (as
>> in webtier-all, for example) so the attached changes also remove the
>> special handling in the distributions/glassfish files.
>>
>> Mostly unrelated - but also involving pom changes - I have also
>> modified various of the appclient/... poms to clean up some of the
>> naming and improve the packaging of the gf-client-bundle.zip file
>> (until we create a client distribution).
>>
>> Snjezana, could you please take a look at the distributions/glassfish
>> changes particularly to make sure I've done the right thing.
>>
>> Jerome or Sahoo, could one of you please look at the pom changes?
>>
>> Many thanks.
>>
>> - Tim
>>
>>
>